vitest-dev · sheremet-va · Jan 16, 2025 · Jan 14, 2025 · Jan 14, 2025 · Jan 15, 2025
diff --git a/packages/browser/src/node/providers/playwright.ts b/packages/browser/src/node/providers/playwright.ts
@@ -185,6 +185,12 @@ export class PlaywrightBrowserProvider implements BrowserProvider {
       })
     }
 
+    // unhandled page crashes will hang vitest process
+    page.on('crash', () => {
+      const session = this.project.vitest._browserSessions.getSession(sessionId)
+      session?.reject(new Error('Page crashed when executing tests'))
+    })
+
     return page
   }
 

diff --git a/packages/utils/src/display.ts b/packages/utils/src/display.ts
@@ -73,8 +73,10 @@ export function stringify(
     })
   }
 
+  // Prevents infinite loop https://github.com/vitest-dev/vitest/issues/7249
+  const nextMaxDepth = maxDepth === Infinity ? Number.MAX_SAFE_INTEGER : Math.floor(maxDepth / 2)
   return result.length >= MAX_LENGTH && maxDepth > 1
-    ? stringify(object, Math.floor(maxDepth / 2))
+    ? stringify(object, nextMaxDepth)
     : result
 }
 

diff --git a/test/browser/test/__snapshots__/utils.test.ts.snap b/test/browser/test/__snapshots__/utils.test.ts.snap
@@ -35,3 +35,33 @@ exports[`prints the element with attributes 1`] = `
   </div>
 </body>"
 `;
+
+exports[`should handle large nested DOM 1`] = `
+"<body>
+
+
+
+
+
+
+  <div>
+    <div>
+      <div>
+        <div>
+          <div>
+            <div>
+              <div>
+                <div>
+                  <div>
+                    <div … />
+                  </div>
+                </div>
+              </div>
+            </div>
+          </div>
+        </div>
+      </div>
+    </div>
+  </div>
+</body>..."
+`;
diff --git a/test/browser/test/browser-crash.test.ts b/test/browser/test/browser-crash.test.ts
@@ -0,0 +1,15 @@
+import { it } from 'vitest';
+
+it.skip('fails gracefully when browser crashes', async () => {
+  let parentDiv = document.createElement("div")
+  let currentDiv = parentDiv;
+
+  // Simulate crash by adding a large number of nodes
+  for (let i = 0; i < 20000; i++) {
+    const newDiv = document.createElement("div")
+    currentDiv.appendChild(newDiv)
+    currentDiv = newDiv
+  }
+
+  document.body.appendChild(parentDiv)
+})
diff --git a/test/browser/test/utils.test.ts b/test/browser/test/utils.test.ts
@@ -37,3 +37,19 @@
 
   expect(await commands.stripVTControlCharacters(prettyDOM())).toMatchSnapshot()
 })
+
+test('should handle large nested DOM', async () => {
+  const depth = 20000;
+
+  // if we try to manipulate dom to add 20000 divs, we get 
+  // max depth exceeded error
+  const openingTags = "<div>".repeat(depth);
+  const closingTags = "</div>".repeat(depth);
+  const domString = `${openingTags}${closingTags}`;
+
+  const parentDiv = document.createElement("div");
+  parentDiv.innerHTML = domString;
+
+  document.body.appendChild(parentDiv);
+  expect(await commands.stripVTControlCharacters(prettyDOM())).toMatchSnapshot()
+});