-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
refactor: merge TestProject with WorkspaceProject
#6906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
TestProject with WorkspaceProject
16bdea0 to
14c6bb6
Compare
AriPerkkio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall direction is great! Thanks for working on this 🙌
Co-authored-by: Ari Perkkiö <[email protected]>
hi-ogawa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't aware of the much of API, but I like the idea of merging and simplifying WorkspaceProject and TestProject 👍
Description
In preparation for the public API. Previously
TestProjectwas a prototype for the public API, but it was hard to work with internally because it was too restrictive. In this PR I decided to merge them together and introduce a sort of convention:_and marked with@internalare internal and not part of the public API. They are striped from the public interface during bundling@deprecatedtag - they will be removed in V3 (we can remove them right away, they shouldn't have been used at all)WorkspaceProjectwas renamed toTestProject- all properties from the test project are now present there. The file was also renamed fromworkspacetoproject.viteor.configwas accessed before the project was initialised. This should catch unexpected errors with a nice stack traceThe public test project API now looks like this (excluding deprecated and private APIs):
TODO:
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.