-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix(coverage): warn if vitest and @vitest/* versions don't match
#6317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sheremet-va
merged 1 commit into
vitest-dev:main
from
AriPerkkio:fix/coverage-warn-version-mismatch
Aug 12, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 50 additions & 0 deletions
50
test/coverage-test/test/mixed-versions-warning.unit.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| import { expect, test, vi } from 'vitest' | ||
| import { configDefaults } from 'vitest/config' | ||
| import V8Provider from '@vitest/coverage-v8' | ||
| import packageJson from '@vitest/coverage-v8/package.json' | ||
| import IstanbulProvider from '@vitest/coverage-istanbul' | ||
| import stripAnsi from 'strip-ansi' | ||
|
|
||
| const version = packageJson.version | ||
|
|
||
| test('v8 provider logs warning if versions do not match', async () => { | ||
| const provider = await V8Provider.getProvider() | ||
| const warn = vi.fn() | ||
|
|
||
| provider.initialize({ | ||
| version: '1.0.0', | ||
| logger: { warn }, | ||
| config: configDefaults, | ||
| } as any) | ||
|
|
||
| expect(warn).toHaveBeenCalled() | ||
|
|
||
| const message = warn.mock.calls[0][0] | ||
|
|
||
| expect(stripAnsi(message)).toMatchInlineSnapshot(` | ||
| "Loaded [email protected] and @vitest/coverage-v8@${version} . | ||
| Running mixed versions is not supported and may lead into bugs | ||
| Update your dependencies and make sure the versions match." | ||
| `) | ||
| }) | ||
|
|
||
| test('istanbul provider logs warning if versions do not match', async () => { | ||
| const provider = await IstanbulProvider.getProvider() | ||
| const warn = vi.fn() | ||
|
|
||
| provider.initialize({ | ||
| version: '1.0.0', | ||
| logger: { warn }, | ||
| config: configDefaults, | ||
| } as any) | ||
|
|
||
| expect(warn).toHaveBeenCalled() | ||
|
|
||
| const message = warn.mock.calls[0][0] | ||
|
|
||
| expect(stripAnsi(message)).toMatchInlineSnapshot(` | ||
| "Loaded [email protected] and @vitest/coverage-istanbul@${version} . | ||
| Running mixed versions is not supported and may lead into bugs | ||
| Update your dependencies and make sure the versions match." | ||
| `) | ||
| }) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.