fix: augment hash for CSS files to prevent chromium erroring by loading previous files #18367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng previous files
sapphi-red
added
feat: css
p4-important
|
|
Member
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI on
✅ analogjs, histoire, ladle, laravel, marko, nuxt, previewjs, quasar, qwik, rakkas, redwoodjs, storybook, vite-environment-examples, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress, vuepress |
patak-dev
approved these changes
Oct 16, 2024
bluwy
approved these changes
Oct 17, 2024
Member
bluwy
left a comment
bluwy
left a comment
There was a problem hiding this comment.
We should also keep an eye in the future if our CSS handling pipeline has changes to the output, and if it does we could probably remove these code again.
sapphi-red
added a commit
that referenced
this pull request
Oct 21, 2024
…ng previous files (#18367)
sapphi-red
added a commit
that referenced
this pull request
Oct 21, 2024
…rroring by loading previous files (#18412)
moonlitusun
pushed a commit
to moonlitusun/vite
that referenced
this pull request
May 25, 2025
…ng previous files (vitejs#18367)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #18038
augmentChunkHashis only called for chunks and not for assets. So I had to change the content to change the hash.