fix(laravel): make mock work #421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
commented
Oct 28, 2025
Comment on lines
-543
to
-546
| const agent = await detect({ cwd: dir, autoInstall: false }) | ||
| if (!agent) { | ||
| throw new Error(`failed to detect packageManager in ${dir}`) | ||
| } |
Member
Author
There was a problem hiding this comment.
This detection returned pnpm, but we should use the agent variable so that options.agent is respected.
Comment on lines
-10
to
+12
| branch: '1.x', | ||
| branch: '2.x', |
Member
Author
There was a problem hiding this comment.
The latest version uses 2.x branch.
Comment on lines
14
to
18
| async beforeTest() { | ||
| const dir = path.resolve(options.workspace, 'vite-plugin') | ||
| const vitestConfigFile = path.join(dir, 'vitest.config.ts') | ||
| fs.writeFileSync(vitestConfigFile, vitestConfig, 'utf-8') | ||
| }, |
Member
Author
There was a problem hiding this comment.
Added vitest.config.ts to exclude Vite from inlined by Vitest. Otherwise the mock here doesn't work.
https://github.com/laravel/vite-plugin/blob/3f7bf9eddc69580796c26890c99065d7259c785e/tests/index.test.ts#L7-L22
Member
There was a problem hiding this comment.
Maybe we can add this info as a comment in code
bluwy
reviewed
Oct 28, 2025
bluwy
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.