Skip to content

Conversation

@Yaytay
Copy link
Contributor

@Yaytay Yaytay commented Mar 18, 2022

Motivation:

Remove @GenIgnore from addConnectionEstablishedCallback

@Yaytay Yaytay requested a review from vietj March 18, 2022 07:17
@Yaytay
Copy link
Contributor Author

Yaytay commented Mar 18, 2022

Hi @vietj,

Please can you take a look at this, is it OK to remove the @GenIgnore from addConnectionEstablishedCallback?
The aim is to make it available to the Rx users.
I'm not getting any errors, but I'm not sure that's a good indication in this case :)

If this isn't OK, is there a way to provide a Rx-compatible method that lets the caller register a method that completes asynchronously?
Either returning a Future or taking in a Handler would be fine.

Note that the connectionEstablishCallback is called multiple times independently, which prevents some options.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants