Skip to content

fix: plugin type is not part of the name #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juanpicado merged 1 commit into from
Dec 26, 2019
Merged

fix: plugin type is not part of the name #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions generators/app/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export default class VerdaccioPluginGenerator extends Generator {
// To access props later use this.props.someAnswer;
// @ts-ignore
this.props = _props;
const { name, pluginType, githubUsername } = _props;
const { name, githubUsername } = _props;
// @ts-ignore
this.props.license = "MIT";
if (githubUsername) {
Expand All @@ -105,7 +105,7 @@ export default class VerdaccioPluginGenerator extends Generator {
}

// @ts-ignore
this.projectName = `verdaccio-${pluginType}-${name}`;
this.projectName = `verdaccio-${name}`;

// @ts-ignore
this.destinationPathName = resolve(this.projectName);
Expand Down
2 changes: 1 addition & 1 deletion test/generator-template.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ describe('template generator', function() {
const license = 'MIT';
const repository = 'verdaccio/generator-test';
const getBuildAsset = (tempRoot, pluginType, item) => {
const prefixPath = path.join(tempRoot, `/verdaccio-${pluginType}-${name}`);
const prefixPath = path.join(tempRoot, `/verdaccio-${name}`);
return `${prefixPath}/${item}`;
}

Expand Down