Skip to content

Conversation

@wbinnssmith
Copy link
Member

@wbinnssmith wbinnssmith commented Oct 6, 2023

This:

  • Updates rust-toolchain to nightly-2023-10-06
  • Removes allowing clippy rules for needless_pass_by_ref_mut and non_canonical_partial_ord_impl as the linked issues appear to have been resolved in [0] and [1] respectively
  • Fixes apparently legitimate issues now reported by clippy

Test Plan: CI

[0] rust-lang/rust-clippy#11492
[1] rust-lang/rust-clippy#11188

Closes WEB-1732

This:
- Updates rust-toolchain to nightly-2023-10-06
- Removes allowing clippy rules for needless_pass_by_ref_mut and non_canonical_partial_ord_impl as the linked issues appear to have been resolved in [0] and [1] respectively
- Fixes apparently legitimate issues now reported by clippy

Test Plan: CI

[0] rust-lang/rust-clippy#11492
[1] rust-lang/rust-clippy#11188
@vercel
Copy link
Contributor

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

11 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Oct 6, 2023 8:50pm
examples-cra-web ⬜️ Ignored (Inspect) Visit Preview Oct 6, 2023 8:50pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Oct 6, 2023 8:50pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Oct 6, 2023 8:50pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Oct 6, 2023 8:50pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Oct 6, 2023 8:50pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Oct 6, 2023 8:50pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Oct 6, 2023 8:50pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Oct 6, 2023 8:50pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Oct 6, 2023 8:50pm
turbo-site ⬜️ Ignored (Inspect) Visit Preview Oct 6, 2023 8:50pm

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

⚠️ This change may fail to build next-swc.

Logs

error: none of the selected packages contains these features: cli

See job summary for details

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Linux Benchmark for d1c1a1e

Test Base PR % Significant %
bench_startup/Turbopack CSR/1000 modules 1214.87ms ± 2.96ms 1230.27ms ± 3.54ms +1.27% +0.20%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 5439.84µs ± 24.00µs 5453.09µs ± 14.40µs +0.24%
bench_hmr_to_eval/Turbopack CSR/1000 modules 5157.38µs ± 30.29µs 5404.20µs ± 219.24µs +4.79%
bench_startup/Turbopack CSR/1000 modules 1214.87ms ± 2.96ms 1230.27ms ± 3.54ms +1.27% +0.20%

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust benchmarks (non-blocking)

See workflow summary for details

wbinnssmith added a commit that referenced this pull request Oct 6, 2023
Along with #6128, this should address most the reported clippy issues.
@wbinnssmith wbinnssmith enabled auto-merge (squash) October 10, 2023 17:00
@wbinnssmith wbinnssmith merged commit b3f79b1 into main Oct 10, 2023
@wbinnssmith wbinnssmith deleted the wbinnssmith/nightly-2023-10-06 branch October 10, 2023 17:00
wbinnssmith added a commit that referenced this pull request Oct 10, 2023
Along with #6128, this should address most the reported clippy issues.


Closes WEB-1734
Zertsov pushed a commit that referenced this pull request Oct 11, 2023
This:
- Updates rust-toolchain to nightly-2023-10-06
- Removes allowing clippy rules for needless_pass_by_ref_mut and
non_canonical_partial_ord_impl as the linked issues appear to have been
resolved in [0] and [1] respectively
- Fixes apparently legitimate issues now reported by clippy

Test Plan: CI

[0] rust-lang/rust-clippy#11492
[1] rust-lang/rust-clippy#11188


Closes WEB-1732
Zertsov pushed a commit that referenced this pull request Oct 11, 2023
Along with #6128, this should address most the reported clippy issues.


Closes WEB-1734
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Oct 13, 2023
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
This:
- Updates rust-toolchain to nightly-2023-10-06
- Removes allowing clippy rules for needless_pass_by_ref_mut and
non_canonical_partial_ord_impl as the linked issues appear to have been
resolved in [0] and [1] respectively
- Fixes apparently legitimate issues now reported by clippy

Test Plan: CI

[0] rust-lang/rust-clippy#11492
[1] rust-lang/rust-clippy#11188


Closes WEB-1732
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
This:
- Updates rust-toolchain to nightly-2023-10-06
- Removes allowing clippy rules for needless_pass_by_ref_mut and
non_canonical_partial_ord_impl as the linked issues appear to have been
resolved in [0] and [1] respectively
- Fixes apparently legitimate issues now reported by clippy

Test Plan: CI

[0] rust-lang/rust-clippy#11492
[1] rust-lang/rust-clippy#11188


Closes WEB-1732
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
This:
- Updates rust-toolchain to nightly-2023-10-06
- Removes allowing clippy rules for needless_pass_by_ref_mut and
non_canonical_partial_ord_impl as the linked issues appear to have been
resolved in [0] and [1] respectively
- Fixes apparently legitimate issues now reported by clippy

Test Plan: CI

[0] rust-lang/rust-clippy#11492
[1] rust-lang/rust-clippy#11188


Closes WEB-1732
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants