-
Notifications
You must be signed in to change notification settings - Fork 2.2k
chore: Upgrade pnpm to 9 #11226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+11,281
−8,464
Merged
chore: Upgrade pnpm to 9 #11226
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
eedd403
chore: Upgrade pnpm to latest
anthonyshew a6061f6
fix docs
anthonyshew 370779e
reset
anthonyshew 739d31e
migrate to 9
anthonyshew 62f940e
WIP cb22c
anthonyshew adfef4f
up to 10
anthonyshew b8d5b0c
WIP 87a54
anthonyshew c00e67a
WIP c39ca
anthonyshew 3c9dfc5
WIP e537b
anthonyshew e8f0fe0
WIP fc4c9
anthonyshew 1e403d6
WIP 8d92f
anthonyshew bf30b08
WIP c7099
anthonyshew 1687c8d
WIP c3bc1
anthonyshew ba05f64
WIP 0dc64
anthonyshew ab86acb
WIP b3c92
anthonyshew 7155266
WIP b2ab9
anthonyshew b42d824
WIP 37a72
anthonyshew 8a95295
WIP 8e5b9
anthonyshew 8f19cd7
WIP f40ce
anthonyshew File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,6 @@ | ||
| auto-install-peers = true | ||
| hoist-pattern[]=vfile-message | ||
| hoist-pattern[]=react | ||
| hoist-pattern[]=react-dom | ||
| resolution-mode=highest | ||
| dedupe-direct-deps=true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
1 change: 1 addition & 0 deletions
1
packages/eslint-plugin-turbo/__fixtures__/workspace-configs-reload/.env
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ROOT_DOT_ENV=true |
6 changes: 6 additions & 0 deletions
6
packages/eslint-plugin-turbo/__fixtures__/workspace-configs-reload/apps/docs/index.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| export default function docs() { | ||
| if (process.env.ENV_1 === undefined) { | ||
| return "does not exist"; | ||
| } | ||
| return "exists"; | ||
| } |
4 changes: 4 additions & 0 deletions
4
packages/eslint-plugin-turbo/__fixtures__/workspace-configs-reload/apps/docs/package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| "name": "docs", | ||
| "version": "1.0.0" | ||
| } |
10 changes: 10 additions & 0 deletions
10
packages/eslint-plugin-turbo/__fixtures__/workspace-configs-reload/apps/docs/turbo.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "$schema": "https://turborepo.com/schema.json", | ||
| "extends": ["//"], | ||
| "pipeline": { | ||
| "build": { | ||
| "dotEnv": ["missing1.env", "missing2.env"], | ||
| "env": ["ENV_3"] | ||
| } | ||
| } | ||
| } |
1 change: 1 addition & 0 deletions
1
packages/eslint-plugin-turbo/__fixtures__/workspace-configs-reload/apps/web/.env
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| WEB_DOT_ENV=true |
15 changes: 15 additions & 0 deletions
15
packages/eslint-plugin-turbo/__fixtures__/workspace-configs-reload/apps/web/index.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| export default function web() { | ||
| if (!process.env.ENV_2) { | ||
| return "bar"; | ||
| } | ||
| if (process.env.NX_DOT_ENV === undefined) { | ||
| return "does not exist"; | ||
| } | ||
| if (process.env.ROOT_DOT_ENV === undefined) { | ||
| return "does not exist"; | ||
| } | ||
| if (process.env.WEB_DOT_ENV === undefined) { | ||
| return "does not exist"; | ||
| } | ||
| return "foo"; | ||
| } |
4 changes: 4 additions & 0 deletions
4
packages/eslint-plugin-turbo/__fixtures__/workspace-configs-reload/apps/web/package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| "name": "web", | ||
| "version": "1.0.0" | ||
| } |
10 changes: 10 additions & 0 deletions
10
packages/eslint-plugin-turbo/__fixtures__/workspace-configs-reload/apps/web/turbo.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "$schema": "https://turborepo.com/schema.json", | ||
| "extends": ["//"], | ||
| "pipeline": { | ||
| "build": { | ||
| "dotEnv": [".env"], | ||
| "env": ["ENV_2", "NEXT_PUBLIC_*", "!NEXT_PUBLIC_EXCLUDE*"] | ||
| } | ||
| } | ||
| } |
14 changes: 14 additions & 0 deletions
14
packages/eslint-plugin-turbo/__fixtures__/workspace-configs-reload/package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "private": true, | ||
| "workspaces": [ | ||
| "apps/*", | ||
| "packages/*" | ||
| ], | ||
| "scripts": { | ||
| "build": "turbo run build" | ||
| }, | ||
| "devDependencies": { | ||
| "turbo": "latest" | ||
| }, | ||
| "packageManager": "[email protected]" | ||
| } |
6 changes: 6 additions & 0 deletions
6
packages/eslint-plugin-turbo/__fixtures__/workspace-configs-reload/packages/ui/index.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| export default function foo() { | ||
| if (!process.env.IS_SERVER) { | ||
| return "bar"; | ||
| } | ||
| return "foo"; | ||
| } |
4 changes: 4 additions & 0 deletions
4
packages/eslint-plugin-turbo/__fixtures__/workspace-configs-reload/packages/ui/package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| "name": "ui", | ||
| "version": "1.0.0" | ||
| } |
9 changes: 9 additions & 0 deletions
9
packages/eslint-plugin-turbo/__fixtures__/workspace-configs-reload/packages/ui/turbo.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "$schema": "https://turborepo.com/schema.json", | ||
| "extends": ["//"], | ||
| "pipeline": { | ||
| "build": { | ||
| "env": ["IS_SERVER"] | ||
| } | ||
| } | ||
| } |
10 changes: 10 additions & 0 deletions
10
packages/eslint-plugin-turbo/__fixtures__/workspace-configs-reload/turbo.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "$schema": "https://turborepo.com/schema.json", | ||
| "globalEnv": ["CI"], | ||
| "globalDotEnv": [".env", "missing.env"], | ||
| "pipeline": { | ||
| "build": { | ||
| "env": ["ENV_1"] | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
package:typesscript was removed from turbo-utils but the@arethetypeswrong/clidependency is still present. This inconsistency will leave unused dependencies and break the package-checks task if turbo-utils is expected to have type checking.View Details
Analysis
Missing package:types script in turbo-utils causes CI failure
What fails: The
package-checkstask in turbo.json depends onpackage:typesscript, but thepackages/turbo-utils/package.jsonis missing this script (only hastest,lint,check-types, andlint:prettier). When CI runsturbo run package-checks --filter={./packages/*}, it will fail for turbo-utils.How to reproduce:
Or via turbo CI command:
Result: The script execution fails with "Missing script: package:types". The @arethetypeswrong/cli dependency remains in devDependencies but is unused.
Expected: The
package:typesscript should be defined like in other type-checked packages (eslint-config-turbo,turbo-gen,turbo-types), which all define:"package:types": "attw --profile node16 --pack". This is required because turbo.json (line 217) defines apackage:typestask that is a dependency ofpackage-checks(line 214), which is run in CI against all packages in ./packages/* per the test-js-packages.yml workflow.Verification: After restoring the missing script,
npm run package:typescompletes successfully with no type issues found.