Skip to content

Conversation

@anthonyshew
Copy link
Contributor

Description

This was written before AI and...well, now we have AI to do stuff like this.

Testing Instructions

CI

@anthonyshew anthonyshew requested a review from a team as a code owner December 6, 2025 20:30
@anthonyshew anthonyshew requested a review from tknickman December 6, 2025 20:30
@vercel
Copy link
Contributor

vercel bot commented Dec 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
examples-basic-web Ready Ready Preview Comment Dec 6, 2025 8:40pm
examples-designsystem-docs Ready Ready Preview Comment Dec 6, 2025 8:40pm
examples-gatsby-web Ready Ready Preview Comment Dec 6, 2025 8:40pm
examples-kitchensink-blog Ready Ready Preview Comment Dec 6, 2025 8:40pm
examples-nonmonorepo Ready Ready Preview Comment Dec 6, 2025 8:40pm
examples-svelte-web Ready Ready Preview Comment Dec 6, 2025 8:40pm
examples-tailwind-web Building Building Preview Comment Dec 6, 2025 8:40pm
examples-vite-web Ready Ready Preview Comment Dec 6, 2025 8:40pm
turbo-site Ready Ready Preview Comment Dec 6, 2025 8:40pm

Copy link
Contributor

@vercel vercel bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Suggestion:

The GitHub Actions workflow is trying to run a check-spelling task that has been removed from the turbo configuration, which will cause the CI pipeline to fail.

View Details
📝 Patch Details
diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
index ec1aae92d..7a34c23a1 100644
--- a/.github/workflows/docs.yml
+++ b/.github/workflows/docs.yml
@@ -36,4 +36,4 @@ jobs:
         uses: ./.github/actions/install-global-turbo
 
       - name: Run docs specific checks
-        run: turbo run check-spelling check-types lint
+        run: turbo run check-types lint

Analysis

Removed check-spelling task breaks GitHub Actions docs workflow

What fails: The .github/workflows/docs.yml workflow attempts to run the check-spelling task via Turbo, but this task has been removed from both docs/site/turbo.json task definitions and docs/site/package.json scripts, causing the workflow to fail.

How to reproduce:

cd docs/site
npx turbo run check-spelling check-types lint

Result: Turbo exits with error code 1:

x Missing tasks in project
  `->   x Could not find task `check-spelling` in project

Expected behavior: The workflow should only run valid tasks defined in the turbo configuration. Since check-spelling has been removed, it should not be referenced in the workflow command.

Fix: Remove check-spelling from the turbo run command in .github/workflows/docs.yml line 39, leaving only:

run: turbo run check-types lint
Fix on Vercel

Copy link
Contributor

@vercel vercel bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Suggestion:

The workflow still references the check-spelling task that has been removed from the Turborepo configuration, which will cause the workflow to fail.

View Details
📝 Patch Details
diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
index ec1aae92d..7a34c23a1 100644
--- a/.github/workflows/docs.yml
+++ b/.github/workflows/docs.yml
@@ -36,4 +36,4 @@ jobs:
         uses: ./.github/actions/install-global-turbo
 
       - name: Run docs specific checks
-        run: turbo run check-spelling check-types lint
+        run: turbo run check-types lint

Analysis

Workflow references removed check-spelling task causing docs CI to fail

What fails: The GitHub Actions workflow in .github/workflows/docs.yml line 39 runs turbo run check-spelling check-types lint, but the check-spelling task was removed from the Turborepo configuration.

How to reproduce: The check-spelling task definition was removed from docs/site/turbo.json and the check-spelling script was removed from docs/site/package.json in commit 98f1d5589 ("docs: Remove spellchecker"), but the workflow file was not updated at the same time. When the workflow runs, Turbo will fail because it cannot find the check-spelling task.

Result: The workflow exits with an error when Turbo attempts to run the non-existent check-spelling task, blocking all PRs that modify documentation files.

Expected: The workflow should run only the tasks that are defined in the Turborepo configuration (check-types and lint).

Fix: Updated the workflow to run turbo run check-types lint instead of turbo run check-spelling check-types lint.

Fix on Vercel

@anthonyshew anthonyshew merged commit 53cce3b into main Dec 6, 2025
181 of 183 checks passed
@anthonyshew anthonyshew deleted the shew/672db branch December 6, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants