-
Notifications
You must be signed in to change notification settings - Fork 2.2k
docs: Remove spellchecker #11214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Remove spellchecker #11214
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Suggestion:
The GitHub Actions workflow is trying to run a check-spelling task that has been removed from the turbo configuration, which will cause the CI pipeline to fail.
View Details
📝 Patch Details
diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
index ec1aae92d..7a34c23a1 100644
--- a/.github/workflows/docs.yml
+++ b/.github/workflows/docs.yml
@@ -36,4 +36,4 @@ jobs:
uses: ./.github/actions/install-global-turbo
- name: Run docs specific checks
- run: turbo run check-spelling check-types lint
+ run: turbo run check-types lint
Analysis
Removed check-spelling task breaks GitHub Actions docs workflow
What fails: The .github/workflows/docs.yml workflow attempts to run the check-spelling task via Turbo, but this task has been removed from both docs/site/turbo.json task definitions and docs/site/package.json scripts, causing the workflow to fail.
How to reproduce:
cd docs/site
npx turbo run check-spelling check-types lintResult: Turbo exits with error code 1:
x Missing tasks in project
`-> x Could not find task `check-spelling` in project
Expected behavior: The workflow should only run valid tasks defined in the turbo configuration. Since check-spelling has been removed, it should not be referenced in the workflow command.
Fix: Remove check-spelling from the turbo run command in .github/workflows/docs.yml line 39, leaving only:
run: turbo run check-types lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Suggestion:
The workflow still references the check-spelling task that has been removed from the Turborepo configuration, which will cause the workflow to fail.
View Details
📝 Patch Details
diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
index ec1aae92d..7a34c23a1 100644
--- a/.github/workflows/docs.yml
+++ b/.github/workflows/docs.yml
@@ -36,4 +36,4 @@ jobs:
uses: ./.github/actions/install-global-turbo
- name: Run docs specific checks
- run: turbo run check-spelling check-types lint
+ run: turbo run check-types lint
Analysis
Workflow references removed check-spelling task causing docs CI to fail
What fails: The GitHub Actions workflow in .github/workflows/docs.yml line 39 runs turbo run check-spelling check-types lint, but the check-spelling task was removed from the Turborepo configuration.
How to reproduce: The check-spelling task definition was removed from docs/site/turbo.json and the check-spelling script was removed from docs/site/package.json in commit 98f1d5589 ("docs: Remove spellchecker"), but the workflow file was not updated at the same time. When the workflow runs, Turbo will fail because it cannot find the check-spelling task.
Result: The workflow exits with an error when Turbo attempts to run the non-existent check-spelling task, blocking all PRs that modify documentation files.
Expected: The workflow should run only the tasks that are defined in the Turborepo configuration (check-types and lint).
Fix: Updated the workflow to run turbo run check-types lint instead of turbo run check-spelling check-types lint.
Description
This was written before AI and...well, now we have AI to do stuff like this.
Testing Instructions
CI