Skip to content

Conversation

@anthonyshew
Copy link
Contributor

@anthonyshew anthonyshew commented Jul 14, 2025

Description

Some fixes for Vitest example. Closes #10659

Testing Instructions

👀

Add 3 new tests to increase coverage from 87.50% to 90.57%:

- test_close_with_timeout: Tests the close_with_timeout method
- test_client_error_handling: Tests error handling when client fails
- test_add_session_id: Tests the add_session_id utility function

These tests cover previously untested code paths including timeout handling,
error scenarios, and utility functions.
@anthonyshew anthonyshew requested a review from a team as a code owner July 14, 2025 14:57
@turbo-orchestrator turbo-orchestrator bot added the area: examples Improvements or additions to examples label Jul 14, 2025
@vercel
Copy link
Contributor

vercel bot commented Jul 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2025 2:59pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2025 2:59pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2025 2:59pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2025 2:59pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2025 2:59pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2025 2:59pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2025 2:59pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2025 2:59pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2025 2:59pm
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2025 2:59pm

@anthonyshew anthonyshew linked an issue Jul 14, 2025 that may be closed by this pull request
1 task
@anthonyshew anthonyshew mentioned this pull request Jul 14, 2025
1 task
@anthonyshew anthonyshew merged commit 3baa897 into main Jul 14, 2025
35 checks passed
@anthonyshew anthonyshew deleted the shew/17c40 branch July 14, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: examples Improvements or additions to examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vitest example confusion

3 participants