Remove all references to @mdx-js/react #80870
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`@mdx-js/react` is actively harmful for Next.js users. `@mdx-js/react` uses React context. React context can’t be used in server components. As a result, users who have `@mdx-js/react` inside their `node_modules` get confusing errors. Removing `@mdx-js/react` from all documentation, tests, and optional peer dependencies, has no drawbacks. Removing `@mdx-js/react` as a `next-mdx-import-source` alias, fixes the confusing errors. Users who insist on using `@mdx-js/react`, can still do this by explicitly specifying the `providerImportSource` option.
ijjk
added
Documentation
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
CodSpeed Performance ReportMerging #80870 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Remove all references to
@mdx-js/react. One occurrence remains in the lockfile due to an indirect dependency.Why?
@mdx-js/reactis actively harmful for Next.js users.@mdx-js/reactuses React context. React context can’t be used in server components. As a result, users who have@mdx-js/reactinside theirnode_modulesget confusing errors.Removing
@mdx-js/reactfrom all documentation, tests, and optional peer dependencies, has no drawbacks. Removing@mdx-js/reactas anext-mdx-import-sourcealias, fixes the confusing errors.Users who insist on using
@mdx-js/react, can still do this by explicitly specifying theproviderImportSourceoption.How?
Search for
@mdx-js/react, and remove all occurences it.