Skip to content

add support for css-in-js ressource mapping in experimental lightningcss-loader #64551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huozhi merged 8 commits into from
Aug 21, 2024
Merged

add support for css-in-js ressource mapping in experimental lightningcss-loader #64551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f18788f
fix css-in-js for lightningcss-loader
jantimon Apr 16, 2024
eb05528
Merge branch 'canary' into feature/css-module-detection
jantimon Apr 16, 2024
230a7df
Merge branch 'canary' into feature/css-module-detection
jantimon Apr 22, 2024
72e1e15
Merge branch 'canary' into feature/css-module-detection
jantimon Aug 20, 2024
a23169c
Merge branch 'canary' into feature/css-module-detection
jantimon Aug 20, 2024
00b3943
Merge branch 'canary' into feature/css-module-detection
jantimon Aug 20, 2024
5fbf42f
Merge branch 'canary' into feature/css-module-detection
jantimon Aug 21, 2024
d7f5fe9
Merge branch 'canary' into feature/css-module-detection
jantimon Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/next/src/build/webpack/config/blocks/css/loaders/global.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ export function getGlobalCssLoader(
cssFileResolve(url, resourcePath, ctx.experimental.urlImports),
import: (url: string, _: any, resourcePath: string) =>
cssFileResolve(url, resourcePath, ctx.experimental.urlImports),
modules: false,
targets: ctx.supportedBrowsers,
postcss,
},
Expand Down
17 changes: 7 additions & 10 deletions packages/next/src/build/webpack/loaders/lightningcss-loader/src/loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ import { ECacheKey } from './interface'

const encoder = new TextEncoder()

const moduleRegExp = /\.module\.\w+$/i

function createUrlAndImportVisitor(
visitorOptions: any,
apis: ApiParam[],
Expand Down Expand Up @@ -364,14 +362,13 @@ export async function LightningCssLoader(
} = transform({
...opts,
visitor,
cssModules:
options.modules && moduleRegExp.test(this.resourcePath)
? {
pattern: process.env.__NEXT_TEST_MODE
? '[name]__[local]'
: '[name]__[hash]__[local]',
}
: undefined,
cssModules: options.modules
? {
pattern: process.env.__NEXT_TEST_MODE
? '[name]__[local]'
: '[name]__[hash]__[local]',
}
: undefined,
filename: this.resourcePath,
code: encoder.encode(source),
sourceMap: this.sourceMap,
Expand Down