throw an error if the val is invalid #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please rebase with master! 😊 |
Contributor
Author
Contributor
|
If you're not familiar with how this works: It basically means that you're syncing the branch on which you've added the changes (within our fork of this repo) with the master branch of this repo. This technique ensures that no conflicts will occur once we decide to merge the PR. |
- give an error response to developers immediately, when calling `ms(null)` or `ms(undefined)` or other invalid things. - to help developers avoid mistakes, and less debug.
adoyle-h
force-pushed
the
feature/checkVal
branch
from
22637bf to
03993f2
Compare
Contributor
Author
|
Sorry, I misread your words. Now it could be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give an error response to developers immediately, when calling
ms(null)orms(undefined)or other invalid things.It can help developers avoid mistakes, and less debug.