Enable Content-Security-Policy header #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses issue vapor#32 by enabling the CSP header in enforcement mode. While the issue mentions a CSP-Report-Only header currently in use, this could not be found in the codebase. The CloudFormation template contains a commented-out CSP configuration which has been enabled and updated to support the current implementation. Changes: - Uncommented the ContentSecurityPolicy configuration in stack.yaml - Added 'unsafe-inline' to script-src and style-src for existing inline code - Added connect-src, base-uri, and form-action directives for additional security The resulting CSP policy: default-src 'none' script-src 'self' 'unsafe-inline' img-src 'self' style-src 'self' 'unsafe-inline' font-src 'self' connect-src 'self' base-uri 'self' form-action 'self' Closes vapor#32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses issue #32 by enabling the CSP header in enforcement mode.
While the issue mentions a CSP-Report-Only header currently in use, this could not be found in the codebase. The CloudFormation template contains a commented-out CSP configuration which has been enabled and updated to support the current implementation.
Changes:
The resulting CSP policy:
default-src 'none' script-src 'self' 'unsafe-inline' img-src 'self' style-src 'self' 'unsafe-inline' font-src 'self' connect-src 'self' base-uri 'self' form-action 'self'
Close #32