Skip to content

/x/net/http upgrade breaking change #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vanng822 merged 3 commits into from
May 2, 2024
Merged

/x/net/http upgrade breaking change #16

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d88b1f8
Break comments by updating /x/net/http
gzuidhof Oct 13, 2022
4e6c722
Add go sum
gzuidhof Oct 13, 2022
9728876
Merge branch 'master' into master
vanng822 May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions premailer/premailer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,3 +504,20 @@ func TestRetainsMsoConditionalComment(t *testing.T) {

assert.Contains(t, resultHTML, `<!--[if mso]><style>.body {font-size: 16px;}</style><![endif]-->`)
}

func TestRetainsComments(t *testing.T) {
html := `<html>
<head>
</head>
<body>
<!-- Comment containing brackets < > -->
</body>
</html>`

p, err := NewPremailerFromString(html, NewOptions())
assert.Nil(t, err)
resultHTML, err := p.Transform()
assert.Nil(t, err)

assert.Contains(t, resultHTML, `<!-- Comment containing brackets < > -->`)
}