Skip to content

Conversation

@ubmarco
Copy link
Member

@ubmarco ubmarco commented Jul 9, 2025

Required as a preparation for #1467.
Python 3.9 reaches its end of life on 2025-10.

The supported Sphinx versions are not touched.

@codecov
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

❌ Patch coverage is 97.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.60%. Comparing base (4e10030) to head (9e71701).
⚠️ Report is 176 commits behind head on master.

Files with missing lines Patch % Lines
sphinx_needs/directives/needbar.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1468      +/-   ##
==========================================
+ Coverage   86.87%   88.60%   +1.72%     
==========================================
  Files          56       61       +5     
  Lines        6532     7259     +727     
==========================================
+ Hits         5675     6432     +757     
+ Misses        857      827      -30     
Flag Coverage Δ
pytests 88.60% <97.50%> (+1.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ubmarco ubmarco marked this pull request as ready for review July 9, 2025 07:58
@ubmarco ubmarco requested a review from chrisjsewell July 9, 2025 07:58
@ubmarco ubmarco mentioned this pull request Jul 9, 2025
Copy link
Member

@danwos danwos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. 👍

@chrisjsewell chrisjsewell changed the title 🔧 Deprecate Python 3.9 ⬆️ Drop Python 3.9 Jul 9, 2025
Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good cheers

@chrisjsewell chrisjsewell merged commit fa75f22 into master Jul 9, 2025
20 checks passed
@chrisjsewell chrisjsewell deleted the mh-rm-py39 branch July 9, 2025 09:02
PierreEtienneJ pushed a commit to PierreEtienneJ/sphinx-needs that referenced this pull request Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants