185 official device simulations #208
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st skip until we generalize the observable though)
…xpectation value via sampling
jordandsullivan
added
the
preview-benchmark-results
📊 Benchmark Summary (ucc-benchmarks-8-core-U22.04)Comparing new 9efbf58 to base 42ca28c:
🔍 See full benchmark table
📜 See standalone benchmark tablesNew results:
Baseline results:
|
📊 Benchmark Summary (ucc-benchmarks-8-core-U22.04)Comparing new 0202486 to base 42ca28c:
🔍 See full benchmark table
📜 See standalone benchmark tablesNew results:
Baseline results:
|
📊 Benchmark Summary (ucc-benchmarks-8-core-U22.04)Comparing new 5bc192e to base 42ca28c:
🔍 See full benchmark table
📜 See standalone benchmark tablesNew results:
Baseline results:
|
📊 Benchmark Summary (ucc-benchmarks-8-core-U22.04)Comparing new 48f88bf to base 42ca28c:
🔍 See full benchmark table
📜 See standalone benchmark tablesNew results:
Baseline results:
|
Contributor
Author
|
This one ended up a smidge more complicated than anticipated:
Simulation resultsHere are a couple plots of the results, for 5 qubits ( and 7 qubits ( Pending the plot improvements in #156 to separate out different benchmark circuits and compare all combinations of noiseless/noisy/compiled/uncompiled, this is what we are seeing. At very least we see the errors are larger for the larger qubit count, as we would expect in NISQ devices. Analysis and next stepsI would expect by default, the noiseless simulations should all have abs relative errors ~0, which is true for Prep-Select and QFT, but not for QCNN and QV. (QAOA also looks wrong, but that I can chalk up this up to the fact the observable is a subset of a larger instance of the problem defined for 10 qubits). This may suggest that our observables are still of not quite right for these benchmark circuits (which may explain the roadblocks I have been hitting in #97 ).
|
jordandsullivan
changed the title
jordandsullivan
commented
Nov 19, 2025
Contributor
Author
There was a problem hiding this comment.
This is fixing the bug I have encountered multiple times in not being able to properly load local data (e.g. #129 ).
jordandsullivan
commented
Nov 19, 2025
| from ..results import SimulationMetrics | ||
|
|
||
|
|
||
| def calc_computational_basis_expectation( |
Contributor
Author
There was a problem hiding this comment.
I think these are no longer used; they were part of debugging.
jordandsullivan
commented
Nov 19, 2025
| latest_date = suite_results.metadata.uid_timestamp.strftime("%Y-%m-%d") | ||
|
|
||
| df = to_df_simulation(suite_results) | ||
| if suite_results is not None: |
Contributor
Author
There was a problem hiding this comment.
Messy, need to remove, this was part of debugging.
jordandsullivan
commented
Nov 20, 2025
Contributor
Author
There was a problem hiding this comment.
Probably overkill since I don't expect we will keep using the "filtered" QAOA instance for smaller qubit counts going forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.