Add ideClient tag via additional bazel params #56
+285
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuklahy
changed the title
mnoah1
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we add detectIdeClient utility function to identify which IDEClient the bsp client is running on.
By default we support cursor and vscode only for now but this can be modified in future to accomodate more clients.
Here we are using bazel's test env flag
--test_env=<ide>to add ide client info.Added test to verify the behaviour.
Coverage does not support additionalBazelParams once its supported we will enable this for coverage as well
IDE is identified by bundleidentifier on mac or path env variable which is when.
Added gitignore to ignore vsix output.