Return the correct message when running tests in recordMode #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for this @wmora. I'm 100% onboard with this change. But if we make it couldn't we move this return statement up into the other |
|
I am trying to get a release out this week so I'll go ahead and accept this PR and then put another one up to move the code around. |
lukaskukacka
pushed a commit
to lukaskukacka/ios-snapshot-test-case
that referenced
this pull request
Jan 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the tests in record mode, they fail with the message:
Snapshot comparison failed: (null)because it was checking for the test result before checking if the test ran inrecordMode. This PR changes the validation order.