Bug commit from vscode

[RigottiG]

After upgrade to husky v5, git commit from vscode always fail (via terminal is ok).

> git -c user.useConfigOnly=true commit --quiet --allow-empty-message --file -
.husky/pre-commit: line 4: npx: command not found
husky - pre-commit hook exited with code 127 (error)

npm version: 7.5.1
node version: 15.8.0

Hooks

// pre-commit
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

npx lint-staged

[typicode]

Hi @RigottiG, could you try https://typicode.github.io/husky/#/?id=command-not-found

[natakina]

The same issue with Webstorm and npm:
.husky/pre-push: 4: npm: not found

I have tried to run npm run lint on pre-commit.
Everything is fine when I use a terminal for commit but not the Webstorm commit dialog.

[feugy]

@RigottiG I also had the issue with VSCode.
I'm using nvm, and creating an ~/.huskyrc file as the Typicode recommended fixed it.

[lensbart]

Having the same issue, but the suggestion by typicode doesn’t work:

# .huskyrc
# See https://typicode.github.io/husky/#/?id=command-not-found
# This loads nvm.sh and sets the correct PATH before running hook
export NVM_DIR="$HOME/.nvm"
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"

I guess the issue can be resolved by updating the $PATH used by VSCode’s Git process, but not sure where to find that.

[yhlchao]

Hi @typicode I have the same issue.

[DeanIfalo]

Hi @typicode
There are too many such problems. May I suggest that this step should be implemented by the package itself(husky.sh).
In this way, most users do not need to set up the .huskyrc file. Although more work needs to be done, I think it is worth it.
I can provide the code I have used(pre-commit)

#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

export NVM_DIR="$HOME/.nvm/nvm.sh"
. "$(dirname $NVM_DIR)/nvm.sh"

export NVM_DIR="$HOME/.nvm"
a=$(nvm ls | grep 'node')
b=${a#*(-> }
v=${b%%[)| ]*}

export PATH="$NVM_DIR/versions/node/$v/bin:$PATH"
yarn lint-staged

Or change "~/.huskyrc" to ".huskyrc". It is convenient for a third party to help modify it.
For the great library, cheers!

[lensbart]

In the meantime, I was able to resolve my issue by setting the right PATH variables via source ~/.profile in the pre-commit file

[emartini]

In the meantime, I was able to resolve my issue by setting the right PATH variables via source ~/.profile in the pre-commit file

I ended in the following post which recommends the same approach in intellij apps
https://ntsim.uk/posts/running-git-hooks-with-environment-variables-in-intellij

[xinkule]

Hi @RigottiG, could you try https://typicode.github.io/husky/#/?id=command-not-found

Is there any way I can solve this within the project folder ? we have a large group of developers (and it's growing), I cannot tell everyone to create a husky config file on their computer to solve the issue.

This problem may trouble most of developers who use vscode's git to commit, cause it might not resolve the correct path, at least in the version 1.58.0

[mxvsh]

Hi @RigottiG, could you try https://typicode.github.io/husky/#/?id=command-not-found

Is there any way I can solve this within the project folder ? we have a large group of developers (and it's growing), I cannot tell everyone to create a husky config file on their computer to solve the issue.

This problem may trouble most of developers who use vscode's git to commit, cause it might not resolve the correct path, at least in the version 1.58.0

you found any solution?

[alexeychikk]

I use VS Code and husky 7. Yesterday everything was working, today I tried to commit and got the same error
.husky/pre-commit: line 4: npm: command not found

[std4453]

Met the same problem, I wonder what command did VS Code use to run the git command? It seem to have ignored my .bashrc, .profile and nvm.fish, which shell does it use?

[alexeychikk]

I downgraded VS Code to the previous version and it fixed the problem.