Skip to content

Django 6.0: add new global settings #2958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tosinibikunle wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Django 6.0: add new global settings #2958

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3d1db4c
added stubs for new global settings in Django 6.0
Tosinibikunle Dec 16, 2025
5a4b37d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 16, 2025
9ae0862
modified: django-stubs/conf/global_settings.pyi
Tosinibikunle Dec 16, 2025
516160d
django-stubs/conf/global_settings.pyi updated
Tosinibikunle Dec 17, 2025
c00c680
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 17, 2025
016ea61
modified: django-stubs/conf/global_settings.pyi
Tosinibikunle Dec 17, 2025
89ce8a2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions django-stubs/conf/global_settings.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,3 +547,10 @@ SECURE_SSL_REDIRECT: bool
##################
SECURE_CSP: Mapping[str, Collection[str] | str]
SECURE_CSP_REPORT_ONLY: Mapping[str, Collection[str] | str]

####################
# django-stubs-ext settings #
Copy link
Member

@sobolevn sobolevn Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not our settings, they are not related to django-stubs-ext

####################

TASKS: dict[str, dict[str, Any]]
Copy link
Member

@sobolevn sobolevn Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, move these settings to proper locations in the file.

URLIZE_ASSUME_HTTPS: bool
3 changes: 0 additions & 3 deletions scripts/stubtest/allowlist_todo_django60.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
django.conf.FORMS_URLFIELD_ASSUME_HTTPS_DEPRECATED_MSG
django.conf.global_settings.FORMS_URLFIELD_ASSUME_HTTPS
Copy link
Member

@sobolevn sobolevn Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This setting is missing from global_settings.py

django.conf.global_settings.TASKS
django.conf.global_settings.URLIZE_ASSUME_HTTPS
django.contrib.admin.AdminSite.password_change_form
django.contrib.admin.ModelAdmin.log_deletion
django.contrib.admin.models.LogEntryManager.log_action
Expand Down
Loading