Skip to content

Conversation

@scoopex
Copy link

@scoopex scoopex commented Sep 24, 2025

Description

Fixes #724

Checklist

  • Make sure changes are covered by existing or new tests.
  • For at least one Python version, make sure test pass on your local environment.
  • Create a file in src/towncrier/newsfragments/. Briefly describe your
    changes, with information useful to end users. Your change will be included in the public release notes.
  • Make sure all GitHub Actions checks are green (they are automatically checking all of the above).
  • Ensure docs/tutorial.rst is still up-to-date.
  • If you add new CLI arguments (or change the meaning of existing ones), make sure docs/cli.rst reflects those changes.
  • If you add new configuration options (or change the meaning of existing ones), make sure docs/configuration.rst reflects those changes.

@scoopex scoopex requested a review from a team as a code owner September 24, 2025 21:35
@scoopex scoopex changed the title Improve issue format check WIP: Improve issue format check Sep 24, 2025
@scoopex scoopex force-pushed the improve_issue_format_check branch from 660f339 to 91841f0 Compare September 24, 2025 21:37
Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
Is this ready for review and merge?

I see the WIP in the title... if the PR is not ready for review, you can mark it as "Draft"

image

To have the PR merged it will need updated tests and documentation.

Also, it needs a newsfragment for the future release notes.
We are dogfooding here... towncrier uses towncrier :)

Let me know if you need help with the docs and tests.

Thanks gain for your contribution.

@scoopex scoopex marked this pull request as draft September 25, 2025 11:44
@scoopex
Copy link
Author

scoopex commented Sep 25, 2025

Sorry, i was aware of that option but had not found that option yesterday :-)

@scoopex scoopex changed the title WIP: Improve issue format check Improve issue format check Sep 25, 2025
@scoopex scoopex force-pushed the improve_issue_format_check branch from 94ad1f6 to 7f0198a Compare September 25, 2025 18:05
@adiroiban
Copy link
Member

No problem.
When creating a new PR, the option is in the "Create PR" button

image

@scoopex scoopex force-pushed the improve_issue_format_check branch 4 times, most recently from 09eae2a to 89c5b46 Compare September 26, 2025 10:13
@scoopex scoopex changed the title Improve issue format check Improve the behavio of "towncrier create" Sep 27, 2025
@scoopex scoopex changed the title Improve the behavio of "towncrier create" Improve the behavior of "towncrier create" Sep 27, 2025
@scoopex scoopex force-pushed the improve_issue_format_check branch from 4d9d8c6 to 4ebde34 Compare October 15, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: More convenient creation of fragments

2 participants