fix(gateway, ratelimiting): fix new clippy errors in the tests #2486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-gateway
AEnterprise
force-pushed
the
AE/fix/clippy
branch
from
6301529 to
ed75866
Compare
vilgotf
reviewed
Dec 12, 2025
Member
vilgotf
left a comment
vilgotf
left a comment
There was a problem hiding this comment.
Ugh can't we just #[allow] this lint? This looks like a hack (the lint should detect the sub method)
Member
Author
|
i figured the function would panic if it overflows? if not its better to use expect then probably in those specific tests. wouldn't allow the entire lint as there are plenty of places where you'd want it to warn you about this |
Member
|
Panic on underflows / expect checked sub are equivalent. I only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.