refactor(gateway): reuse 'now' instant for poll_acquire
#2393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vilgotf
added
c-gateway
AEnterprise
approved these changes
Dec 6, 2024
Erk-
approved these changes
Dec 6, 2024
viztea
pushed a commit
to eara-bot/twilight
that referenced
this pull request
Feb 15, 2025
…s#2393) We're always calling `clock_gettime()` when acquiring a permit even if we've just done so already in when checking readiness. This is not a big deal performance wise, but it feels counterintuitive to not reuse already fetched resources as if the alrorithm required it (it does not).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're always calling
clock_gettime()when acquiring a permit even if we've just done so already in when checking readiness. This is not a big deal performance wise, but it feels counterintuitive to not reuse already fetched resources as if the alrorithm required it (it does not).