make Page.frameNavigated accept additional keywords #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n keyword type: exception
Author
|
For more information: running apparition's specs generates a bajillion of the same error, and this fixed it. |
Owner
|
Thanks |
|
@twalpole Any chance of issuing a patch release for this? Running specs is quite noisy right now on 0.6.0. Thanks for your work on maintaining this driver! |
jxjj
added a commit
to UMN-LATIS/z
that referenced
this pull request
Aug 6, 2021
The latest version can create a lot of noise with "unknown keyword: :type: " warnings This is fixed in twalpole/apparition#79
This was referenced Aug 6, 2021
jxjj
added a commit
to UMN-LATIS/z
that referenced
this pull request
Aug 6, 2021
The latest version of apparition gem can create a lot of noise with `unknown keyword: :type:` warnings This is fixed in <twalpole/apparition#79>, but the patch hasn't been released yet. We change to github source in the interim. Once patch is released, we should change back. See issue #58.
|
Hi @twalpole , I just wanted to follow up with the patch request above. Thank you so much! |
|
In the meantime, just in case you stumble across this before a new version is released, this in your Gemfile will include the fix: |
|
Thank you so much!
…On Wed, Aug 18, 2021 at 3:42 PM Taylor Brown ***@***.***> wrote:
In the meantime, just in case you stumble across this before a new version
is released, this in your Gemfile will include the fix:
gem 'apparition', github: 'twalpole/apparition', ref:
'ca86be4d54af835d531dbcd2b86e7b2c77f85f34'
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#79 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABHZQFC323WE42CKALGXQILT5QELLANCNFSM5AYJMGKA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
zaparka
added a commit
to hmcts/hwf-staffapp
that referenced
this pull request
Dec 10, 2021
zaparka
added a commit
to hmcts/hwf-staffapp
that referenced
this pull request
Dec 10, 2021
PragTob
pushed a commit
to simplecov-ruby/simplecov
that referenced
this pull request
Jan 17, 2022
This avoids unnecessary warnings in the test output. See twalpole/apparition#79
gsmendoza
added a commit
to solidusio/solidus_starter_frontend
that referenced
this pull request
Jun 2, 2022
…when running solidus_starter_frontend specs
Goal
----
As a solidus_starter_frontend contributor
I would like to fix the "Unexpected inner loop exception: unknown keyword: type"
message that appears when we run solidus_starter_frontend specs
So that we can remove the noise when running the specs.
Expected behavior
-----------------
When I run `bundle exec rspec spec/system/cart_spec.rb:13`
Then I should see it run successfully
Actual behavior
---------------
I see the JS messages:
```
solidus_starter_frontend 06:33:14 $ bundle exec rspec spec/system/cart_spec.rb:13
Provide a CODECOV_TOKEN environment variable to enable Codecov uploads
We are transitioning to a new way of loading factories for extensions.
Be sure this extension does not load factories using require but uses
the load_for() method in its spec_helper.rb, eg:
SolidusDevSupport::TestingSupport::Factories.load_for(ExtensionName1::Engine, ExtensionName2::Engine)
This will load Solidus Core factories right before the ones defined in
lib/extension_name/testing_support/factories/*_factory.rb or
lib/extension_name/testing_support/factories.rb
This message will be removed when all extensions are updated.
Run options: include {:focus=>true, :locations=>{"./spec/system/cart_spec.rb"=>[13]}}
Randomized with seed 36718
Unexpected inner loop exception: unknown keyword: type: unknown keyword: type: ["/home/gsmendoza/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/apparition-0.6.0/lib/capybara/apparition/page.rb:466:in `block in register_event_handlers'", "/home/gsmendoza/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/apparition-0.6.0/lib/capybara/apparition/driver/chrome_client.rb:209:in `block in process_handlers'", "/home/gsmendoza/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/apparition-0.6.0/lib/capybara/apparition/driver/chrome_client.rb:207:in `each'", "/home/gsmendoza/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/apparition-0.6.0/lib/capybara/apparition/driver/chrome_client.rb:207:in `process_handlers'", "/home/gsmendoza/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/apparition-0.6.0/lib/capybara/apparition/driver/chrome_client.rb:185:in `block in process_messages'", "/home/gsmendoza/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/apparition-0.6.0/lib/capybara/apparition/driver/chrome_client.rb:175:in `loop'", "/home/gsmendoza/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/apparition-0.6.0/lib/capybara/apparition/driver/chrome_client.rb:175:in `process_messages'", "/home/gsmendoza/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/apparition-0.6.0/lib/capybara/apparition/driver/chrome_client.rb:215:in `block in start_threads'"]
Unexpected inner loop exception: unknown keyword: type: unknown keyword: type: ["/home/gsmendoza/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/apparition-0.6.0/lib/capybara/apparition/page.rb:466:in `block in register_event_handlers'", "/home/gsmendoza/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/apparition-0.6.0/lib/capybara/apparition/driver/chrome_client.rb:209:in `block in process_handlers'", "/home/gsmendoza/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/apparition-0.6.0/lib/capybara/apparition/driver/chrome_client.rb:207:in `each'", "/home/gsmendoza/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/apparition-0.6.0/lib/capybara/apparition/driver/chrome_client.rb:207:in `process_handlers'", "/home/gsmendoza/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/apparition-0.6.0/lib/capybara/apparition/driver/chrome_client.rb:185:in `block in process_messages'", "/home/gsmendoza/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/apparition-0.6.0/lib/capybara/apparition/driver/chrome_client.rb:175:in `loop'", "/home/gsmendoza/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/apparition-0.6.0/lib/capybara/apparition/driver/chrome_client.rb:175:in `process_messages'", "/home/gsmendoza/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/apparition-0.6.0/lib/capybara/apparition/driver/chrome_client.rb:215:in `block in start_threads'"]
Unexpected inner loop exception: unknown keyword: type: unknown keyword: type: ["/home/gsmendoza/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/apparition-0.6.0/lib/capybara/apparition/page.rb:466:in `block in register_event_handlers'", "/home/gsmendoza/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/apparition-0.6.0/lib/capybara/apparition/driver/chrome_client.rb:209:in `block in process_handlers'", "/home/gsmendoza/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/apparition-0.6.0/lib/capybara/apparition/driver/chrome_client.rb:207:in `each'", "/home/gsmendoza/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/apparition-0.6.0/lib/capybara/apparition/driver/chrome_client.rb:207:in `process_handlers'", "/home/gsmendoza/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/apparition-0.6.0/lib/capybara/apparition/driver/chrome_client.rb:185:in `block in process_messages'", "/home/gsmendoza/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/apparition-0.6.0/lib/capybara/apparition/driver/chrome_client.rb:175:in `loop'", "/home/gsmendoza/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/apparition-0.6.0/lib/capybara/apparition/driver/chrome_client.rb:175:in `process_messages'", "/home/gsmendoza/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/apparition-0.6.0/lib/capybara/apparition/driver/chrome_client.rb:215:in `block in start_threads'"]
.
Finished in 8.76 seconds (files took 3.24 seconds to load)
1 example, 0 failures
Randomized with seed 36718
```
Cause
-----
See twalpole/apparition#79 - make Page.frameNavigated
accept additional keywords #79
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running apparition with Chrome on WSL2, which updated this morning, started throwing this error on every frame navigation:
Unexpected inner loop exception: unknown keyword: :type: unknown keyword: :type: ["/home/david/apparition/lib/capybara/apparition/page.rb:466:inblock in register_event_handlers'", "/home/david/apparition/lib/capybara/apparition/driver/chrome_client.rb:209:in
block in process_handlers'", "/home/david/apparition/lib/capybara/appari tion/driver/chrome_client.rb:207:ineach'", "/home/david/apparition/lib/capybara/apparition/driver/chrome_client.rb:207:inprocess_handlers'", "/home/david/apparitio n/lib/capybara/apparition/driver/chrome_client.rb:185:inblock in process_messages'", "/home/david/apparition/lib/capybara/apparition/driver/chrome_client.rb:175:inloop'", "/home/david/apparition/lib/capybara/apparition/driver/chrome_client.rb:175:inprocess_messages'", "/home/david/apparition/lib/capybara/apparition/driver/chrome_client.rb:215:in
block in start_threads'"]The examples still ran fine. So I changed the session handler to accept all keywords and log them for debug, following the example of other event handlers in that method.