Overhaul user-facing messages #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some patches do not modify an existing file in place. Instead they add, remove, or rename a file. This is a "non-modified patch", and will commute with everything in the stack. If all patches are non-modified, then no changes will be absorbed, so warn the user and stop processing. Even users that auto-stage changes will be warned, since they would've run git-absorb with the expectation that it would do something. Otherwise, if only some patches are non-modified, we can continue processing with a warning. In this case, do not warn users who auto-stage changes, since they may routinely keep untracked files in their working directory. Before this, 1. users who did not auto-stage were warned when nothing was staged. We have a more explicit warning and early exit above now. 2. there were staged changes (auto-staged or not) and all the patches were non-modified, we'd warn "Could not find a commit to fix up", which is accurate, but not as informative.
|
@tummychow does not yet incorporate |
blairconrad
force-pushed
the
better-logs
branch
from
c0c2843 to
1541024
Compare
Merged
|
OMG. Merged without complaint. Thanks for entertaining my wacky ideas, @tummychow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #172.
Specifically, parts 3 and 4 of the proposed plan are completed here:
stack::working_stackto also return a reason why the commit-finding search ended(e.g. reached a merge commit, hit the stack depth limit, etc.)
help the lib.rs code present better messages to the user
The first 4 commits alter the flow through
run_with_repo, sometimes exiting early,and sometimes delaying logging until we know the full effect of searching for
commits in the stack.
Then the last commit incorporates the reason the stack ends into the warnings
(if any) to the user.
Also closes #21.