Finalizing eval #13
Merged
Finalizing eval #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed mse
…ow positive, and negative sign is encoded as normal token
- float(loss) prevented backwards path through number loss - torch.nanmean led to nan gradient
…itespace, that this whitespace simply disappeard
zausin33
requested review from
Larspennig and
jannisborn
and removed request for
Larspennig and
jannisborn
fixed problems with checkpoint loading added tests for training and checkpoint loading added positional embeddings to xval
# Conflicts: # data/grade-school-math/grade_school_math/prepocess_data.py # src/encoding_decoding/numerical_encodings.py # src/evaluation.py # src/number_token_loss.py # src/run_language_modeling.py # src/tokenizer/rt_tokenizer.py # src/tokenizer/xval_tokenizer.py # src/transformer_backbone/t5/t5_xval.py # tests/test_number_token_loss.py # tests/tokenizer/test_rt_tokenizer.py
jannisborn
pushed a commit
that referenced
this pull request
Jul 18, 2025
Finalizing eval Former-commit-id: 19940f1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.