Add support for ALTER COLUMN ... SET NOT NULL in engine and PostgreSQL connector
#27765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs
clickhouse
chenjian2664
force-pushed
the
jack/set-column-not-null
branch
from
87ece51 to
f83863e
Compare
ebyhr
reviewed
Dec 28, 2025
| throw semanticException(NOT_SUPPORTED, statement, "Cannot modify hidden column"); | ||
| } | ||
| if (!columnMetadata.isNullable()) { | ||
| throw semanticException(NOT_SUPPORTED, statement, "Column is already not nullable"); |
Member
There was a problem hiding this comment.
Have you confirmed the expected behavior in SQL standard? P.873 in ISO_IEC_9075-2(E)_Foundation
Contributor
Author
There was a problem hiding this comment.
The P.873 doesn't say the behavior if the column is already not nullable, it's depended on the implementation right?
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/execution/TestSetNotNullConstraintConstraintTask.java
Show resolved
Hide resolved
core/trino-parser/src/main/java/io/trino/sql/tree/SetNotNullConstraint.java
Outdated
Show resolved
Hide resolved
core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorMetadata.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/tracing/TracingConnectorMetadata.java
Outdated
Show resolved
Hide resolved
ebyhr
changed the title
ALTER COLUMN ... SET NOT NULL in PostgreSQL connectorALTER COLUMN ... SET NOT NULL in engine and PostgreSQL connector
chenjian2664
force-pushed
the
jack/set-column-not-null
branch
from
f9186f5 to
ddd9a6e
Compare
github-actions
bot
added
iceberg
chenjian2664
force-pushed
the
jack/set-column-not-null
branch
3 times, most recently
from
9944a21 to
4e413fc
Compare
chenjian2664
force-pushed
the
jack/set-column-not-null
branch
2 times, most recently
from
1d8d070 to
c4c6661
Compare
chenjian2664
force-pushed
the
jack/set-column-not-null
branch
from
c4c6661 to
1195d42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #27404
Additional context and related issues
Release notes
() This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: