-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Update single store version in TestingSingleStoreServer #27754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update single store version in TestingSingleStoreServer #27754
Conversation
...in/trino-singlestore/src/test/java/io/trino/plugin/singlestore/TestingSingleStoreServer.java
Outdated
Show resolved
Hide resolved
...in/trino-singlestore/src/test/java/io/trino/plugin/singlestore/TestingSingleStoreServer.java
Outdated
Show resolved
Hide resolved
985dcdf to
b53a1f1
Compare
|
(The latest image is still failing locally on Mac. moving to draft for now.) |
21df709 to
afcddf2
Compare
|
(image above |
2c1e205 to
be7634d
Compare
be7634d to
efeb400
Compare
|
(ready for review) |
|
Could you confirm CI failure? https://github.com/trinodb/trino/actions/runs/20510230185/job/58930448578?pr=27754 |
Locally, it's not failing. The issue is similar to prestodb/presto#21900. It suggests to clean-up the disk space. But we are doing this already: trino/.github/bin/free-disk-space.sh Lines 24 to 31 in be3fd10
|
|
(trying out with explicit cleanup) |
cfe61ac to
bb86bf8
Compare
image above `0.2.62` only supports x86-64 architecture. So using `0.2.62` image for latest version.
bb86bf8 to
787ca9e
Compare
Reducing the resource usage resolves the issue. (https://www.singlestore.com/forum/t/available-disk-space-error/3802/9) |
| } | ||
|
|
||
| @Test | ||
| @Override |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please leave a code comment explaining why this test is overridden?

Description
Running
SingleStoreQueryRunnerlocally on Mac (Silicon) hangs the startup and eventually fails because we were usingsinglestoredb-dev:0.2.51(which is compatible with SingleStore version8.9) with SingleStore version7.8. Updating the compatible version fixes the startup.This PR also reverts #12235 newer version of SingleStore(MemSql) fails to insert invalid date.
Reference:
Release notes
(X) This is not user-visible or is docs only, and no release notes are required.