Skip to content

Conversation

@silverlyra
Copy link
Contributor

Motivation

Tables with yes–no columns (or other kinds of binary distinctions) can be difficult to 👀 visually scan if the column in each row contains “yes” or “no”. It’s usually easier to spot the “yes” rows if they have a symbol there that the “no” rows do not.

The tables of available features on axum and axum-extra have this issue on their Default? column where the default features are indicated.

Solution

Before After
Screenshot 2025-11-09 at 11 43 28 PM Screenshot 2025-11-09 at 11 43 55 PM

This PR removes the “No” values, and replaces “Yes” with a checkmark. Scaled down here to fit within the PR description space, the easier readability is (imo!) even more obvious.

For screen readers, I wrapped the checkmark in a <span> which sets the aria-label to “Default feature”, so this should be clearer even when the table is not being visually read.

I appreciate everyone who’s worked to ship and maintain such a delightful library as Axum! 🙏🏻

Copy link
Collaborator

@yanns yanns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is great 💚

@jplatte jplatte merged commit 3ef6c5d into tokio-rs:main Nov 10, 2025
18 checks passed
@silverlyra silverlyra deleted the feature-tables-default branch November 11, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants