Use extensions directly in from_request_parts #3542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to go through `Extension<T>::from_request_parts` and build an error to throw away when we have direct access to `parts.extensions`.
jplatte
approved these changes
Oct 30, 2025
Member
jplatte
left a comment
jplatte
left a comment
There was a problem hiding this comment.
This also gets rid of a pointless await point. Thanks!
Collaborator
|
nice! |
jplatte
pushed a commit
that referenced
this pull request
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We don't need to go through
Extension<T>::from_request_partsand build an error to throw away when we have direct access toparts.extensions.Solution
Use
parts.extensionsdirectly to get the cached value.