Skip to content

fix(electron): web dev server ws does not work for electron renderer #12711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2025
Merged

fix(electron): web dev server ws does not work for electron renderer #12711

merged 1 commit into from
Jun 12, 2025

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Jun 5, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Updated the default WebSocket connection settings for the development server to use port 8080.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 5, 2025 •
edited
Loading

Walkthrough

The change updates the Webpack Dev Server configuration in the CLI bundle script, specifically altering the webSocketURL property in the client settings to use port 8080 instead of port 0.

Changes

File(s) Change Summary
tools/cli/src/bundle.ts Updated webSocketURL in Webpack Dev Server client config from port 0 to port 8080

Possibly related PRs

Suggested labels

app:electron

Suggested reviewers

  • fengmk2

Poem

A hop to port eight-oh-eight-oh,
Where WebSockets now shall flow.
No more guessing which port to go,
The dev server’s path we clearly show.
With every build and every run,
The bundle script’s work is never done!
🐇✨

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pengx17 Graphite App
Copy link
Collaborator Author

pengx17 commented Jun 5, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@pengx17 pengx17 marked this pull request as ready for review June 5, 2025 02:34
@graphite-app graphite-app bot requested a review from a team June 5, 2025 02:34
@codecov Codecov
Copy link

codecov bot commented Jun 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.65%. Comparing base (c7aebd0) to head (991f039).
Report is 30 commits behind head on canary.

Additional details and impacted files 
@@            Coverage Diff             @@
##           canary   #12711      +/-   ##
==========================================
- Coverage   55.87%   55.65%   -0.22%     
==========================================
  Files        2652     2652              
  Lines      125209   125209              
  Branches    19806    19803       -3     
==========================================
- Hits        69958    69689     -269     
- Misses      53124    53288     +164     
- Partials     2127     2232     +105
Flag Coverage Δ
server-test 79.02% <ø> (ø)
unittest 31.62% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

coderabbitai[bot]
coderabbitai bot reviewed Jun 5, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c7aebd0 and 991f039.

📒 Files selected for processing (1)
  • tools/cli/src/bundle.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (520)
  • GitHub Check: test-build-mobile-app / android
  • GitHub Check: test-build-mobile-app / ios
  • GitHub Check: Desktop Test (macos-latest, macos, arm64, aarch64-apple-darwin, true)
  • GitHub Check: Desktop Test (windows-latest, windows, x64, x86_64-pc-windows-msvc, true)
  • GitHub Check: Desktop bundle check (ubuntu-latest, linux, x64, x86_64-unknown-linux-gnu, true)
  • GitHub Check: Desktop Test (ubuntu-latest, linux, x64, x86_64-unknown-linux-gnu, true)
  • GitHub Check: Desktop bundle check (windows-latest, windows, x64, x86_64-pc-windows-msvc, true)
  • GitHub Check: Cloud Desktop E2E Test
  • GitHub Check: Cloud E2E Test 6/6
  • GitHub Check: Cloud E2E Test 4/6
  • GitHub Check: Cloud E2E Test 3/6
  • GitHub Check: Cloud E2E Test 2/6
  • GitHub Check: Cloud E2E Test 5/6
  • GitHub Check: Cloud E2E Test 1/6
  • GitHub Check: Server Test (6, 8)
  • GitHub Check: Server Test (3, 8)
  • GitHub Check: Server Test (7, 8)
  • GitHub Check: Server Test (2, 8)
  • GitHub Check: Server Test (5, 8)
  • GitHub Check: Server Test (4, 8)
  • GitHub Check: Server Test (1, 8)
  • GitHub Check: Server Test (0, 8)
  • GitHub Check: Server E2E Test
  • GitHub Check: Server Test with Elasticsearch
  • GitHub Check: Unit Test (3)
  • GitHub Check: Unit Test (1)
  • GitHub Check: Unit Test (4)
  • GitHub Check: Unit Test (5)
  • GitHub Check: Unit Test (2)
  • GitHub Check: y-octo binding test on aarch64-pc-windows-msvc
  • GitHub Check: y-octo binding test on x86_64-pc-windows-msvc
  • GitHub Check: E2E Test (7)
  • GitHub Check: E2E Test (9)
  • GitHub Check: E2E Test (6)
  • GitHub Check: fuzzing
  • GitHub Check: E2E Test (8)
  • GitHub Check: E2E Test (5)
  • GitHub Check: E2E Test (10)
  • GitHub Check: E2E Test (2)
  • GitHub Check: E2E Test (3)
  • GitHub Check: E2E Test (4)
  • GitHub Check: E2E Test (1)
  • GitHub Check: E2E BlockSuite Test (3)
  • GitHub Check: E2E BlockSuite Test (6)
  • GitHub Check: E2E BlockSuite Test (5)
  • GitHub Check: E2E Mobile Test (2)
  • GitHub Check: E2E Mobile Test (5)
  • GitHub Check: E2E Mobile Test (1)
  • GitHub Check: E2E BlockSuite Test (4)
  • GitHub Check: E2E Mobile Test (3)
  • GitHub Check: Analyze (javascript, affine)
  • GitHub Check: Analyze (javascript, blocksuite)
  • GitHub Check: test-build-mobile-app / android
  • GitHub Check: test-build-mobile-app / ios
  • GitHub Check: Desktop Test (macos-latest, macos, arm64, aarch64-apple-darwin, true)
  • GitHub Check: Desktop Test (windows-latest, windows, x64, x86_64-pc-windows-msvc, true)
  • GitHub Check: Desktop bundle check (ubuntu-latest, linux, x64, x86_64-unknown-linux-gnu, true)
  • GitHub Check: Desktop Test (ubuntu-latest, linux, x64, x86_64-unknown-linux-gnu, true)
  • GitHub Check: Desktop bundle check (windows-latest, windows, x64, x86_64-pc-windows-msvc, true)
  • GitHub Check: Cloud Desktop E2E Test
  • GitHub Check: Cloud E2E Test 6/6
  • GitHub Check: Cloud E2E Test 4/6
  • GitHub Check: Cloud E2E Test 3/6
  • GitHub Check: Cloud E2E Test 2/6
  • GitHub Check: Cloud E2E Test 5/6
  • GitHub Check: Cloud E2E Test 1/6
  • GitHub Check: Server Test (6, 8)
  • GitHub Check: Server Test (3, 8)
  • GitHub Check: Server Test (7, 8)
  • GitHub Check: Server Test (2, 8)
  • GitHub Check: Server Test (5, 8)
  • GitHub Check: Server Test (4, 8)
  • GitHub Check: Server Test (1, 8)
  • GitHub Check: Server Test (0, 8)
  • GitHub Check: Server E2E Test
  • GitHub Check: Server Test with Elasticsearch
  • GitHub Check: Unit Test (3)
  • GitHub Check: Unit Test (1)
  • GitHub Check: Unit Test (4)
  • GitHub Check: Unit Test (5)
  • GitHub Check: Unit Test (2)
  • GitHub Check: y-octo binding test on aarch64-pc-windows-msvc
  • GitHub Check: y-octo binding test on x86_64-pc-windows-msvc
  • GitHub Check: E2E Test (7)
  • GitHub Check: E2E Test (9)
  • GitHub Check: E2E Test (6)
  • GitHub Check: fuzzing
  • GitHub Check: E2E Test (8)
  • GitHub Check: E2E Test (5)
  • GitHub Check: E2E Test (10)
  • GitHub Check: E2E Test (2)
  • GitHub Check: E2E Test (3)
  • GitHub Check: E2E Test (4)
  • GitHub Check: E2E Test (1)
  • GitHub Check: E2E BlockSuite Test (3)
  • GitHub Check: E2E BlockSuite Test (6)
  • GitHub Check: E2E BlockSuite Test (5)
  • GitHub Check: E2E Mobile Test (2)
  • GitHub Check: E2E Mobile Test (5)
  • GitHub Check: E2E Mobile Test (1)
  • GitHub Check: E2E BlockSuite Test (4)
  • GitHub Check: E2E Mobile Test (3)
  • GitHub Check: Analyze (javascript, affine)
  • GitHub Check: Analyze (javascript, blocksuite)
  • GitHub Check: test-build-mobile-app / android
  • GitHub Check: test-build-mobile-app / ios
  • GitHub Check: Desktop Test (macos-latest, macos, arm64, aarch64-apple-darwin, true)
  • GitHub Check: Desktop Test (windows-latest, windows, x64, x86_64-pc-windows-msvc, true)
  • GitHub Check: Desktop bundle check (ubuntu-latest, linux, x64, x86_64-unknown-linux-gnu, true)
  • GitHub Check: Desktop Test (ubuntu-latest, linux, x64, x86_64-unknown-linux-gnu, true)
  • GitHub Check: Desktop bundle check (windows-latest, windows, x64, x86_64-pc-windows-msvc, true)
  • GitHub Check: Cloud Desktop E2E Test
  • GitHub Check: Cloud E2E Test 6/6
  • GitHub Check: Cloud E2E Test 4/6
  • GitHub Check: Cloud E2E Test 3/6
  • GitHub Check: Cloud E2E Test 2/6
  • GitHub Check: Cloud E2E Test 5/6
  • GitHub Check: Cloud E2E Test 1/6
  • GitHub Check: Server Test (6, 8)
  • GitHub Check: Server Test (3, 8)
  • GitHub Check: Server Test (7, 8)
  • GitHub Check: Server Test (2, 8)
  • GitHub Check: Server Test (5, 8)
  • GitHub Check: Server Test (4, 8)
  • GitHub Check: Server Test (1, 8)
  • GitHub Check: Server Test (0, 8)
  • GitHub Check: Server E2E Test
  • GitHub Check: Server Test with Elasticsearch
  • GitHub Check: Unit Test (3)
  • GitHub Check: Unit Test (1)
  • GitHub Check: Unit Test (4)
  • GitHub Check: Unit Test (5)
  • GitHub Check: Unit Test (2)
  • GitHub Check: y-octo binding test on aarch64-pc-windows-msvc
  • GitHub Check: y-octo binding test on x86_64-pc-windows-msvc
  • GitHub Check: E2E Test (7)
  • GitHub Check: E2E Test (9)
  • GitHub Check: E2E Test (6)
  • GitHub Check: fuzzing
  • GitHub Check: E2E Test (8)
  • GitHub Check: E2E Test (5)
  • GitHub Check: E2E Test (10)
  • GitHub Check: E2E Test (2)
  • GitHub Check: E2E Test (3)
  • GitHub Check: E2E Test (4)
  • GitHub Check: E2E Test (1)
  • GitHub Check: E2E BlockSuite Test (3)
  • GitHub Check: E2E BlockSuite Test (6)
  • GitHub Check: E2E BlockSuite Test (5)
  • GitHub Check: E2E Mobile Test (2)
  • GitHub Check: E2E Mobile Test (5)
  • GitHub Check: E2E Mobile Test (1)
  • GitHub Check: E2E BlockSuite Test (4)
  • GitHub Check: E2E Mobile Test (3)
  • GitHub Check: Analyze (javascript, affine)
  • GitHub Check: Analyze (javascript, blocksuite)
  • GitHub Check: test-build-mobile-app / android
  • GitHub Check: test-build-mobile-app / ios
  • GitHub Check: Desktop Test (macos-latest, macos, arm64, aarch64-apple-darwin, true)
  • GitHub Check: Desktop Test (windows-latest, windows, x64, x86_64-pc-windows-msvc, true)
  • GitHub Check: Desktop bundle check (ubuntu-latest, linux, x64, x86_64-unknown-linux-gnu, true)
  • GitHub Check: Desktop Test (ubuntu-latest, linux, x64, x86_64-unknown-linux-gnu, true)
  • GitHub Check: Desktop bundle check (windows-latest, windows, x64, x86_64-pc-windows-msvc, true)
  • GitHub Check: Cloud Desktop E2E Test
  • GitHub Check: Cloud E2E Test 6/6
  • GitHub Check: Cloud E2E Test 4/6
  • GitHub Check: Cloud E2E Test 3/6
  • GitHub Check: Cloud E2E Test 2/6
  • GitHub Check: Cloud E2E Test 5/6
  • GitHub Check: Cloud E2E Test 1/6
  • GitHub Check: Server Test (6, 8)
  • GitHub Check: Server Test (3, 8)
  • GitHub Check: Server Test (7, 8)
  • GitHub Check: Server Test (2, 8)
  • GitHub Check: Server Test (5, 8)
  • GitHub Check: Server Test (4, 8)
  • GitHub Check: Server Test (1, 8)
  • GitHub Check: Server Test (0, 8)
  • GitHub Check: Server E2E Test
  • GitHub Check: Server Test with Elasticsearch
  • GitHub Check: Unit Test (3)
  • GitHub Check: Unit Test (1)
  • GitHub Check: Unit Test (4)
  • GitHub Check: Unit Test (5)
  • GitHub Check: Unit Test (2)
  • GitHub Check: y-octo binding test on aarch64-pc-windows-msvc
  • GitHub Check: y-octo binding test on x86_64-pc-windows-msvc
  • GitHub Check: E2E Test (7)
  • GitHub Check: E2E Test (9)
  • GitHub Check: E2E Test (6)
  • GitHub Check: fuzzing
  • GitHub Check: E2E Test (8)
  • GitHub Check: E2E Test (5)
  • GitHub Check: E2E Test (10)
  • GitHub Check: E2E Test (2)
  • GitHub Check: E2E Test (3)
  • GitHub Check: E2E Test (4)
  • GitHub Check: E2E Test (1)
  • GitHub Check: E2E BlockSuite Test (3)
  • GitHub Check: E2E BlockSuite Test (6)
  • GitHub Check: E2E BlockSuite Test (5)
  • GitHub Check: E2E Mobile Test (2)
  • GitHub Check: E2E Mobile Test (5)
  • GitHub Check: E2E Mobile Test (1)
  • GitHub Check: E2E BlockSuite Test (4)
  • GitHub Check: E2E Mobile Test (3)
  • GitHub Check: Analyze (javascript, affine)
  • GitHub Check: Analyze (javascript, blocksuite)
  • GitHub Check: test-build-mobile-app / android
  • GitHub Check: test-build-mobile-app / ios
  • GitHub Check: Desktop Test (macos-latest, macos, arm64, aarch64-apple-darwin, true)
  • GitHub Check: Desktop Test (windows-latest, windows, x64, x86_64-pc-windows-msvc, true)
  • GitHub Check: Desktop bundle check (ubuntu-latest, linux, x64, x86_64-unknown-linux-gnu, true)
  • GitHub Check: Desktop Test (ubuntu-latest, linux, x64, x86_64-unknown-linux-gnu, true)
  • GitHub Check: Desktop bundle check (windows-latest, windows, x64, x86_64-pc-windows-msvc, true)
  • GitHub Check: Cloud Desktop E2E Test
  • GitHub Check: Cloud E2E Test 6/6
  • GitHub Check: Cloud E2E Test 4/6
  • GitHub Check: Cloud E2E Test 3/6
  • GitHub Check: Cloud E2E Test 2/6
  • GitHub Check: Cloud E2E Test 5/6
  • GitHub Check: Cloud E2E Test 1/6
  • GitHub Check: Server Test (6, 8)
  • GitHub Check: Server Test (3, 8)
  • GitHub Check: Server Test (7, 8)
  • GitHub Check: Server Test (2, 8)
  • GitHub Check: Server Test (5, 8)
  • GitHub Check: Server Test (4, 8)
  • GitHub Check: Server Test (1, 8)
  • GitHub Check: Server Test (0, 8)
  • GitHub Check: Server E2E Test
  • GitHub Check: Server Test with Elasticsearch
  • GitHub Check: Unit Test (3)
  • GitHub Check: Unit Test (1)
  • GitHub Check: Unit Test (4)
  • GitHub Check: Unit Test (5)
  • GitHub Check: Unit Test (2)
  • GitHub Check: y-octo binding test on aarch64-pc-windows-msvc
  • GitHub Check: y-octo binding test on x86_64-pc-windows-msvc
  • GitHub Check: E2E Test (7)
  • GitHub Check: E2E Test (9)
  • GitHub Check: E2E Test (6)
  • GitHub Check: fuzzing
  • GitHub Check: E2E Test (8)
  • GitHub Check: E2E Test (5)
  • GitHub Check: E2E Test (10)
  • GitHub Check: E2E Test (2)
  • GitHub Check: E2E Test (3)
  • GitHub Check: E2E Test (4)
  • GitHub Check: E2E Test (1)
  • GitHub Check: E2E BlockSuite Test (3)
  • GitHub Check: E2E BlockSuite Test (6)
  • GitHub Check: E2E BlockSuite Test (5)
  • GitHub Check: E2E Mobile Test (2)
  • GitHub Check: E2E Mobile Test (5)
  • GitHub Check: E2E Mobile Test (1)
  • GitHub Check: E2E BlockSuite Test (4)
  • GitHub Check: E2E Mobile Test (3)
  • GitHub Check: Analyze (javascript, affine)
  • GitHub Check: Analyze (javascript, blocksuite)
  • GitHub Check: test-build-mobile-app / android
  • GitHub Check: test-build-mobile-app / ios
  • GitHub Check: Desktop Test (macos-latest, macos, arm64, aarch64-apple-darwin, true)
  • GitHub Check: Desktop Test (windows-latest, windows, x64, x86_64-pc-windows-msvc, true)
  • GitHub Check: Desktop bundle check (ubuntu-latest, linux, x64, x86_64-unknown-linux-gnu, true)
  • GitHub Check: Desktop Test (ubuntu-latest, linux, x64, x86_64-unknown-linux-gnu, true)
  • GitHub Check: Desktop bundle check (windows-latest, windows, x64, x86_64-pc-windows-msvc, true)
  • GitHub Check: Cloud Desktop E2E Test
  • GitHub Check: Cloud E2E Test 6/6
  • GitHub Check: Cloud E2E Test 4/6
  • GitHub Check: Cloud E2E Test 3/6
  • GitHub Check: Cloud E2E Test 2/6
  • GitHub Check: Cloud E2E Test 5/6
  • GitHub Check: Cloud E2E Test 1/6
  • GitHub Check: Server Test (6, 8)
  • GitHub Check: Server Test (3, 8)
  • GitHub Check: Server Test (7, 8)
  • GitHub Check: Server Test (2, 8)
  • GitHub Check: Server Test (5, 8)
  • GitHub Check: Server Test (4, 8)
  • GitHub Check: Server Test (1, 8)
  • GitHub Check: Server Test (0, 8)
  • GitHub Check: Server E2E Test
  • GitHub Check: Server Test with Elasticsearch
  • GitHub Check: Unit Test (3)
  • GitHub Check: Unit Test (1)
  • GitHub Check: Unit Test (4)
  • GitHub Check: Unit Test (5)
  • GitHub Check: Unit Test (2)
  • GitHub Check: y-octo binding test on aarch64-pc-windows-msvc
  • GitHub Check: y-octo binding test on x86_64-pc-windows-msvc
  • GitHub Check: E2E Test (7)
  • GitHub Check: E2E Test (9)
  • GitHub Check: E2E Test (6)
  • GitHub Check: fuzzing
  • GitHub Check: E2E Test (8)
  • GitHub Check: E2E Test (5)
  • GitHub Check: E2E Test (10)
  • GitHub Check: E2E Test (2)
  • GitHub Check: E2E Test (3)
  • GitHub Check: E2E Test (4)
  • GitHub Check: E2E Test (1)
  • GitHub Check: E2E BlockSuite Test (3)
  • GitHub Check: E2E BlockSuite Test (6)
  • GitHub Check: E2E BlockSuite Test (5)
  • GitHub Check: E2E Mobile Test (2)
  • GitHub Check: E2E Mobile Test (5)
  • GitHub Check: E2E Mobile Test (1)
  • GitHub Check: E2E BlockSuite Test (4)
  • GitHub Check: E2E Mobile Test (3)
  • GitHub Check: Analyze (javascript, affine)
  • GitHub Check: Analyze (javascript, blocksuite)
  • GitHub Check: test-build-mobile-app / android
  • GitHub Check: test-build-mobile-app / ios
  • GitHub Check: Desktop Test (macos-latest, macos, arm64, aarch64-apple-darwin, true)
  • GitHub Check: Desktop Test (windows-latest, windows, x64, x86_64-pc-windows-msvc, true)
  • GitHub Check: Desktop bundle check (ubuntu-latest, linux, x64, x86_64-unknown-linux-gnu, true)
  • GitHub Check: Desktop Test (ubuntu-latest, linux, x64, x86_64-unknown-linux-gnu, true)
  • GitHub Check: Desktop bundle check (windows-latest, windows, x64, x86_64-pc-windows-msvc, true)
  • GitHub Check: Cloud Desktop E2E Test
  • GitHub Check: Cloud E2E Test 6/6
  • GitHub Check: Cloud E2E Test 4/6
  • GitHub Check: Cloud E2E Test 3/6
  • GitHub Check: Cloud E2E Test 2/6
  • GitHub Check: Cloud E2E Test 5/6
  • GitHub Check: Cloud E2E Test 1/6
  • GitHub Check: Server Test (6, 8)
  • GitHub Check: Server Test (3, 8)
  • GitHub Check: Server Test (7, 8)
  • GitHub Check: Server Test (2, 8)
  • GitHub Check: Server Test (5, 8)
  • GitHub Check: Server Test (4, 8)
  • GitHub Check: Server Test (1, 8)
  • GitHub Check: Server Test (0, 8)
  • GitHub Check: Server E2E Test
  • GitHub Check: Server Test with Elasticsearch
  • GitHub Check: Unit Test (3)
  • GitHub Check: Unit Test (1)
  • GitHub Check: Unit Test (4)
  • GitHub Check: Unit Test (5)
  • GitHub Check: Unit Test (2)
  • GitHub Check: y-octo binding test on aarch64-pc-windows-msvc
  • GitHub Check: y-octo binding test on x86_64-pc-windows-msvc
  • GitHub Check: E2E Test (7)
  • GitHub Check: E2E Test (9)
  • GitHub Check: E2E Test (6)
  • GitHub Check: fuzzing
  • GitHub Check: E2E Test (8)
  • GitHub Check: E2E Test (5)
  • GitHub Check: E2E Test (10)
  • GitHub Check: E2E Test (2)
  • GitHub Check: E2E Test (3)
  • GitHub Check: E2E Test (4)
  • GitHub Check: E2E Test (1)
  • GitHub Check: E2E BlockSuite Test (3)
  • GitHub Check: E2E BlockSuite Test (6)
  • GitHub Check: E2E BlockSuite Test (5)
  • GitHub Check: E2E Mobile Test (2)
  • GitHub Check: E2E Mobile Test (5)
  • GitHub Check: E2E Mobile Test (1)
  • GitHub Check: E2E BlockSuite Test (4)
  • GitHub Check: E2E Mobile Test (3)
  • GitHub Check: Analyze (javascript, affine)
  • GitHub Check: Analyze (javascript, blocksuite)
  • GitHub Check: test-build-mobile-app / android
  • GitHub Check: test-build-mobile-app / ios
  • GitHub Check: Desktop Test (macos-latest, macos, arm64, aarch64-apple-darwin, true)
  • GitHub Check: Desktop Test (windows-latest, windows, x64, x86_64-pc-windows-msvc, true)
  • GitHub Check: Desktop bundle check (ubuntu-latest, linux, x64, x86_64-unknown-linux-gnu, true)
  • GitHub Check: Desktop Test (ubuntu-latest, linux, x64, x86_64-unknown-linux-gnu, true)
  • GitHub Check: Desktop bundle check (windows-latest, windows, x64, x86_64-pc-windows-msvc, true)
  • GitHub Check: Cloud Desktop E2E Test
  • GitHub Check: Cloud E2E Test 6/6
  • GitHub Check: Cloud E2E Test 4/6
  • GitHub Check: Cloud E2E Test 3/6
  • GitHub Check: Cloud E2E Test 2/6
  • GitHub Check: Cloud E2E Test 5/6
  • GitHub Check: Cloud E2E Test 1/6
  • GitHub Check: Server Test (6, 8)
  • GitHub Check: Server Test (3, 8)
  • GitHub Check: Server Test (7, 8)
  • GitHub Check: Server Test (2, 8)
  • GitHub Check: Server Test (5, 8)
  • GitHub Check: Server Test (4, 8)
  • GitHub Check: Server Test (1, 8)
  • GitHub Check: Server Test (0, 8)
  • GitHub Check: Server E2E Test
  • GitHub Check: Server Test with Elasticsearch
  • GitHub Check: Unit Test (3)
  • GitHub Check: Unit Test (1)
  • GitHub Check: Unit Test (4)
  • GitHub Check: Unit Test (5)
  • GitHub Check: Unit Test (2)
  • GitHub Check: y-octo binding test on aarch64-pc-windows-msvc
  • GitHub Check: y-octo binding test on x86_64-pc-windows-msvc
  • GitHub Check: E2E Test (7)
  • GitHub Check: E2E Test (9)
  • GitHub Check: E2E Test (6)
  • GitHub Check: fuzzing
  • GitHub Check: E2E Test (8)
  • GitHub Check: E2E Test (5)
  • GitHub Check: E2E Test (10)
  • GitHub Check: E2E Test (2)
  • GitHub Check: E2E Test (3)
  • GitHub Check: E2E Test (4)
  • GitHub Check: E2E Test (1)
  • GitHub Check: E2E BlockSuite Test (3)
  • GitHub Check: E2E BlockSuite Test (6)
  • GitHub Check: E2E BlockSuite Test (5)
  • GitHub Check: E2E Mobile Test (2)
  • GitHub Check: E2E Mobile Test (5)
  • GitHub Check: E2E Mobile Test (1)
  • GitHub Check: E2E BlockSuite Test (4)
  • GitHub Check: E2E Mobile Test (3)
  • GitHub Check: Analyze (javascript, affine)
  • GitHub Check: Analyze (javascript, blocksuite)
  • GitHub Check: test-build-mobile-app / android
  • GitHub Check: test-build-mobile-app / ios
  • GitHub Check: Desktop Test (macos-latest, macos, arm64, aarch64-apple-darwin, true)
  • GitHub Check: Desktop Test (windows-latest, windows, x64, x86_64-pc-windows-msvc, true)
  • GitHub Check: Desktop bundle check (ubuntu-latest, linux, x64, x86_64-unknown-linux-gnu, true)
  • GitHub Check: Desktop Test (ubuntu-latest, linux, x64, x86_64-unknown-linux-gnu, true)
  • GitHub Check: Desktop bundle check (windows-latest, windows, x64, x86_64-pc-windows-msvc, true)
  • GitHub Check: Cloud Desktop E2E Test
  • GitHub Check: Cloud E2E Test 6/6
  • GitHub Check: Cloud E2E Test 4/6
  • GitHub Check: Cloud E2E Test 3/6
  • GitHub Check: Cloud E2E Test 2/6
  • GitHub Check: Cloud E2E Test 5/6
  • GitHub Check: Cloud E2E Test 1/6
  • GitHub Check: Server Test (6, 8)
  • GitHub Check: Server Test (3, 8)
  • GitHub Check: Server Test (7, 8)
  • GitHub Check: Server Test (2, 8)
  • GitHub Check: Server Test (5, 8)
  • GitHub Check: Server Test (4, 8)
  • GitHub Check: Server Test (1, 8)
  • GitHub Check: Server Test (0, 8)
  • GitHub Check: Server E2E Test
  • GitHub Check: Server Test with Elasticsearch
  • GitHub Check: Unit Test (3)
  • GitHub Check: Unit Test (1)
  • GitHub Check: Unit Test (4)
  • GitHub Check: Unit Test (5)
  • GitHub Check: Unit Test (2)
  • GitHub Check: y-octo binding test on aarch64-pc-windows-msvc
  • GitHub Check: y-octo binding test on x86_64-pc-windows-msvc
  • GitHub Check: E2E Test (7)
  • GitHub Check: E2E Test (9)
  • GitHub Check: E2E Test (6)
  • GitHub Check: fuzzing
  • GitHub Check: E2E Test (8)
  • GitHub Check: E2E Test (5)
  • GitHub Check: E2E Test (10)
  • GitHub Check: E2E Test (2)
  • GitHub Check: E2E Test (3)
  • GitHub Check: E2E Test (4)
  • GitHub Check: E2E Test (1)
  • GitHub Check: E2E BlockSuite Test (3)
  • GitHub Check: E2E BlockSuite Test (6)
  • GitHub Check: E2E BlockSuite Test (5)
  • GitHub Check: E2E Mobile Test (2)
  • GitHub Check: E2E Mobile Test (5)
  • GitHub Check: E2E Mobile Test (1)
  • GitHub Check: E2E BlockSuite Test (4)
  • GitHub Check: E2E Mobile Test (3)
  • GitHub Check: Analyze (javascript, affine)
  • GitHub Check: Analyze (javascript, blocksuite)
  • GitHub Check: test-build-mobile-app / android
  • GitHub Check: test-build-mobile-app / ios
  • GitHub Check: Desktop Test (macos-latest, macos, arm64, aarch64-apple-darwin, true)
  • GitHub Check: Desktop Test (windows-latest, windows, x64, x86_64-pc-windows-msvc, true)
  • GitHub Check: Desktop bundle check (ubuntu-latest, linux, x64, x86_64-unknown-linux-gnu, true)
  • GitHub Check: Desktop Test (ubuntu-latest, linux, x64, x86_64-unknown-linux-gnu, true)
  • GitHub Check: Desktop bundle check (windows-latest, windows, x64, x86_64-pc-windows-msvc, true)
  • GitHub Check: Cloud Desktop E2E Test
  • GitHub Check: Cloud E2E Test 6/6
  • GitHub Check: Cloud E2E Test 4/6
  • GitHub Check: Cloud E2E Test 3/6
  • GitHub Check: Cloud E2E Test 2/6
  • GitHub Check: Cloud E2E Test 5/6
  • GitHub Check: Cloud E2E Test 1/6
  • GitHub Check: Server Test (6, 8)
  • GitHub Check: Server Test (3, 8)
  • GitHub Check: Server Test (7, 8)
  • GitHub Check: Server Test (2, 8)
  • GitHub Check: Server Test (5, 8)
  • GitHub Check: Server Test (4, 8)
  • GitHub Check: Server Test (1, 8)
  • GitHub Check: Server Test (0, 8)
  • GitHub Check: Server E2E Test
  • GitHub Check: Server Test with Elasticsearch
  • GitHub Check: Unit Test (3)
  • GitHub Check: Unit Test (1)
  • GitHub Check: Unit Test (4)
  • GitHub Check: Unit Test (5)
  • GitHub Check: Unit Test (2)
  • GitHub Check: y-octo binding test on aarch64-pc-windows-msvc
  • GitHub Check: y-octo binding test on x86_64-pc-windows-msvc
  • GitHub Check: E2E Test (7)
  • GitHub Check: E2E Test (9)
  • GitHub Check: E2E Test (6)
  • GitHub Check: fuzzing
  • GitHub Check: E2E Test (8)
  • GitHub Check: E2E Test (5)
  • GitHub Check: E2E Test (10)
  • GitHub Check: E2E Test (2)
  • GitHub Check: E2E Test (3)
  • GitHub Check: E2E Test (4)
  • GitHub Check: E2E Test (1)
  • GitHub Check: E2E BlockSuite Test (3)
  • GitHub Check: E2E BlockSuite Test (6)
  • GitHub Check: E2E BlockSuite Test (5)
  • GitHub Check: E2E Mobile Test (2)
  • GitHub Check: E2E Mobile Test (5)
  • GitHub Check: E2E Mobile Test (1)
  • GitHub Check: E2E BlockSuite Test (4)
  • GitHub Check: E2E Mobile Test (3)
  • GitHub Check: Analyze (javascript, affine)
  • GitHub Check: Analyze (javascript, blocksuite)

@pengx17 pengx17 merged commit d12954f into canary Jun 12, 2025
117 checks passed
@pengx17 pengx17 deleted the 06-05-fix_electron_web_dev_server_ws_does_not_work_for_electron_renderer branch June 12, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@forehalo forehalo forehalo approved these changes

Assignees
No one assigned
Labels
mod:dev
Projects
AFFiNE Project
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pengx17 @forehalo