-
-
Notifications
You must be signed in to change notification settings - Fork 990
vectorstores: Add support for OpenAI Organization ID header in Chroma #646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
22d650c to
ed8dc02
Compare
tmc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@tmc, I've just added a new release for Chroma-go (v.0.0.2) with the OpenAI org change that @AshDevFr , pushed a few days back - https://github.com/amikos-tech/chroma-go/releases/tag/v0.0.2 @AshDevFr, do you mind updating your |
ed8dc02 to
7c2b90c
Compare
|
Updated the version |
|
@tazarov I see that the I'll update this PR soon |
7c2b90c to
602e574
Compare
|
It should be good to go. |
|
@AshDevFr, yeah, sorry about that. Since this was a breaking change I wanted to move it to 0.1.x tag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great! Can we make this "OpenAI" vs "OpenAi" in terms of exposed interface to be more consistent with existing code? (with that it can go in). (also needs rebase)
|
Do you mean changing
I don't mind refactoring the |
602e574 to
434b4f1
Compare
|
we should be using "OpenAI" instead of "OpenAi" |
* Update `chroma-go` to the latest version * Add error handling to NewOpenAIEmbeddingFunction * Add a new property to the store (`openaiOrganization`) and pass it to `chroma-go`
434b4f1 to
94db963
Compare
|
Ok I changed the whole |
94db963 to
7947f6d
Compare
|
We could be really careful and alias and deprecate it but I think release notes will suffice. Once we get larger and more popular we can be more delicate with backwards incompatible changes. |
tmc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chroma-goto the latest version (To include this PRopenaiOrganization) and pass it tochroma-goThe goal of this PR is to add support for the OpenAI Organization ID header in Chroma. It is already supported here by the OpenAI client in Langchain but it was missing from the chroma implementation.
PR Checklist
memory: add interfaces for X, Yorutil: add whizzbang helpers).Fixes #123).golangci-lintchecks.