-
-
Notifications
You must be signed in to change notification settings - Fork 5
check-pages.sh: add a check for the see also section #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Let's also add it to the tldr-bot: https://github.com/tldr-pages/tldr/blob/main/scripts/check-pr.sh |
I'm out of juice. Can you do it? |
It is simply copying this PR, and add it to check-pr.sh. Although this PR doesn't lint yet ;) |
|
When I tested this, I had a jumbled mess before cleaning it for a commit. Now I can't get the script to work like it used to. found the mismatching |
|
Using |
|
I think it's now good to go. |
|
|
Thanks. I learned about submodules while working on these changes. |
|
This solution feels so stupid but it works. |
|
Please don't update the submodule yourself. This is handled by an automated process. |
|
How else am I supposed to get the see also translation template? A simple git pull did nothing. |
You can get the template locally, but don't commit the tldr submodule itself in this PR. |
|
Is it still possible to salvage this branch? Match the submodule version and quickly merge to main before to bot updates it again? |
|
Well, definitely not merge this PR to main just yet. I will check if I can clean this branch. |
1372bb5 to
29423da
Compare
|
I want to test this branch first, but I don't have the time for it at the moment. |
I don't know how to fully test this. Tested with running
./check-pages.shwithtldr/pages/downloaded alongside it. I got this file in responsemissing-tldr-pages.txt