Skip to content

Conversation

@Managor
Copy link
Member

@Managor Managor commented Dec 11, 2025

I don't know how to fully test this. Tested with running ./check-pages.sh with tldr/pages/ downloaded alongside it. I got this file in response
missing-tldr-pages.txt

@sebastiaanspeck
Copy link
Member

@Managor
Copy link
Member Author

Managor commented Dec 11, 2025

Let's also add it to the tldr-bot: https://github.com/tldr-pages/tldr/blob/main/scripts/check-pr.sh

I'm out of juice. Can you do it?

@sebastiaanspeck
Copy link
Member

Let's also add it to the tldr-bot: https://github.com/tldr-pages/tldr/blob/main/scripts/check-pr.sh

I'm out of juice. Can you do it?

It is simply copying this PR, and add it to check-pr.sh. Although this PR doesn't lint yet ;)

@Managor
Copy link
Member Author

Managor commented Dec 12, 2025

When I tested this, I had a jumbled mess before cleaning it for a commit. Now I can't get the script to work like it used to. found the mismatching " " but now I'm struggling with other things

@sebastiaanspeck
Copy link
Member

Using grep -P would also break the script to use on macOS.

@Managor
Copy link
Member Author

Managor commented Dec 14, 2025

I think it's now good to go.

@sebastiaanspeck sebastiaanspeck marked this pull request as draft December 14, 2025 05:02
@sebastiaanspeck
Copy link
Member

I don't know how to fully test this. Tested with running ./check-pages.sh with tldr/pages/ downloaded alongside it. I got this file in response

missing-tldr-pages.txt

tldr is included in the repository as a Git submodule, so you could've also updated your submodule instead of downloading the repository yourself.

@Managor
Copy link
Member Author

Managor commented Dec 16, 2025

Thanks. I learned about submodules while working on these changes.

@Managor
Copy link
Member Author

Managor commented Dec 17, 2025

This solution feels so stupid but it works.

@Managor Managor marked this pull request as ready for review December 17, 2025 05:52
@sebastiaanspeck
Copy link
Member

Please don't update the submodule yourself. This is handled by an automated process.

@Managor
Copy link
Member Author

Managor commented Dec 17, 2025

How else am I supposed to get the see also translation template? A simple git pull did nothing.

@sebastiaanspeck
Copy link
Member

How else am I supposed to get the see also translation template? A simple git pull did nothing.

You can get the template locally, but don't commit the tldr submodule itself in this PR.

@Managor
Copy link
Member Author

Managor commented Dec 17, 2025

Is it still possible to salvage this branch? Match the submodule version and quickly merge to main before to bot updates it again?

@sebastiaanspeck
Copy link
Member

Well, definitely not merge this PR to main just yet. I will check if I can clean this branch.

@sebastiaanspeck
Copy link
Member

I want to test this branch first, but I don't have the time for it at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants