-
Notifications
You must be signed in to change notification settings - Fork 5
Adds wagmi guide #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Adds wagmi guide #294
Conversation
This UI handles user authentication (passkeys via Turnkey), transaction signing, and communication with the dApp via `postMessage`. | ||
It securely interacts with the Turnkey API. Reference the `popup-wallet-demo`'s `@/apps/wallet` provides a concrete example. | ||
|
||
**EIP-1193 Provider:** A JavaScript class implementing the [EIP-1193](https://eips.ethereum.org/EIPS/eip-1193) standard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where would @turnkey/eip-1193-provider
slot into this? is there an opportunity to have it fit in here, or will clients have to roll their own regardless?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor sidenote — do we want to remove this specific reference here: https://github.com/tkhq/popup-wallet-demo/blob/6eb0b732d6a57dad229a39120299a1762040e0ad/apps/dapp/lib/eip1193-provider.ts#L210C9-L210C26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no not exactly, at least not currently as the eip-1193-provider was built, we'd need a way like a plugin system of sorts that allows overriding or capture certain rpc requests i.e. eth_requestAccounts
so the user could add their custom popup logic if they desire
@andrewkmin I moved the wagmi doc to this PR since we'll be merging that in at the same time! |
No description provided.