Skip to content

feat: add typescript type definitions #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add typescript type definitions #24

wants to merge 1 commit into from

Conversation

JamieMagee
Copy link

These are already available as @types/github-url-from-git, but it's preferred to provide typescript definitions from the package itself

See DefinitelyTyped/DefinitelyTyped#38576

@JamieMagee JamieMagee mentioned this pull request Sep 25, 2019
Closed
21 tasks
@ChristianMurphy
Copy link

@JamieMagee would it be possible to include the type tests as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamieMagee @ChristianMurphy