Improved the 'git-info' command (color, submodule, config) #867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auxiliary message distracting from the main message
add ability to customize git-config, git-log commands from .gitconfig file
spacewander
requested changes
Aug 24, 2020
bin/git-info
Outdated
|
|
||
| get_config() { | ||
| git config --list | ||
| cmd_get_config="$(git config --get-all extras.info.config-grep)" |
Collaborator
There was a problem hiding this comment.
Now we prefer to use git-extras as the namespace, like git config --get git-extras.pr.remote.
bin/git-info
Outdated
| NORMAL="$(tput sgr0)" | ||
| if [ "$1" = "--color" ] || [ "$2" = "--color" ] || \ | ||
| [ "$1" = "-c" ] || [ "$2" = "-c" ] ; then | ||
| COLOR_TITLE="$GREEN" |
Collaborator
There was a problem hiding this comment.
Better to mention that -c only affects the title in the documentation.
bin/git-info
Outdated
|
|
||
| if test "$1" != "--no-config"; then | ||
| echon "## Configuration (.git/config):" | ||
| if [ "$1" != "--no-config" ] && [ "$2" != "--no-config" ]; then |
Collaborator
There was a problem hiding this comment.
Better to move the argument checks together at the top of the script.
should use 'git-extra' name to configure via git config options.
spacewander
approved these changes
Aug 25, 2020
Collaborator
|
@yuravg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I see #755, but did something similar in another way
added:
note:
I hope this will be useful