Skip to content

Conversation

@btmurrell
Copy link
Contributor

No description provided.

@spacewander
Copy link
Collaborator

@btmurrell
Will you address the two remain issues - fixing the edge case and adding two more example? Thanks!

@btmurrell
Copy link
Contributor Author

@spacewander -- now that i think this PR is complete, i just noticed in git-changelog, this command is using git config changelog.OPTION for preferences. that is, there is a precedent for preferences in the git-extras commands... and it does not prefix with git-extras. perhaps the git-extras namespacing is superfluous? i think continuity among all commands would be best.... i'm happy to remove the namespace.

@spacewander
Copy link
Collaborator

@btmurrell
Thanks for your report. I think adding git-extras prefix is better. But for backward compatibility, if nobody complains, we won't change it.

@btmurrell
Copy link
Contributor Author

ok, @spacewander. i will squash now.

@spacewander spacewander self-requested a review June 19, 2019 10:12
@spacewander
Copy link
Collaborator

@btmurrell
Will you squash the commit so that I can merge it? Thanks!

@btmurrell btmurrell force-pushed the preference-for-create-branch branch from f8e3b1b to 7d3ab83 Compare June 21, 2019 13:21
@btmurrell
Copy link
Contributor Author

Sorry @spacewander -- i tried to squash earlier, but did the push wrong. did it this time, but got it to two commits. botched, but hopefully clean enough.

@spacewander spacewander merged commit a26f1e6 into tj:master Jun 22, 2019
@spacewander
Copy link
Collaborator

@btmurrell
Merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants