Fix: Dev: /E option required to install on Win 10 {b17134} or higher
#732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n of Windows 10 (**_Build 17134_**) Changes: - Added small text line to debug files being written iff environment variable `%DEBUG%` is `true` - Added option `/E` to both MORE commands used inside install.cmd for copying files.
spacewander
requested changes
Oct 9, 2018
| TYPE "%GITEXTRAS%\helper\git-extra-utility" >> "%PREFIX%\bin\%%i" | ||
| MORE +2 "%GITEXTRAS%\bin\%%i" >> "%PREFIX%\bin\%%i" | ||
|
|
||
| :: Added /E Option for Installation Fix On Windows 10 Higher Version |
Collaborator
There was a problem hiding this comment.
I think it would be safer to use REM instead of :: in the block.
https://stackoverflow.com/a/42148114/2278997
| echo Installing binaries... | ||
| FOR /R "%GITEXTRAS%\bin" %%i in (*.*) DO ( | ||
| :: Fixation for Windows 10.0.17134 Build 17134 (Won't install without /E) | ||
| :: Echo file being written for testing |
Collaborator
There was a problem hiding this comment.
IMHO, these two comments don't look like necessary. The first one could be put just before MORE command, and the second one is too straightforward.
|
|
||
| FOR %%i in (%COMMANDS_WITHOUT_REPO%) DO ( | ||
| :: Fixation for Windows 10.0.17134 Build 17134 (Won't install without /E) | ||
| :: Echo file being written for testing |
Collaborator
|
@sachin-gupta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
%DEBUG%istrue/Eto both MORE commands used inside install.cmd for copying files.