feat(git-release): push tags first to help ci tools not miss them #690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you are buliding on CircleCI for example, pushing the commits first can lead to a race where CI env will not see the tags since the pull happened before the tags were finished pushing. It should be fully safe (and backwards-compatible) to change the order of pushing to the remote.
spacewander
requested changes
Jan 24, 2018
| git tag $version -a -m "$msg" \ | ||
| && git push $remote \ | ||
| && git push $remote --tags \ | ||
| && git push $remote \ |
Collaborator
There was a problem hiding this comment.
IMHO, we could omit this line because git push $remote --tags already pushes the commit to remote branch.
Contributor
Author
There was a problem hiding this comment.
I don't know if that's the case, I'll run a quick test.
Contributor
Author
There was a problem hiding this comment.
I just did a test. The tag will be pushed, and you can find the commit if you reference it by SHA. However, the commit will not be pushed to the branch, so we still need both commands.
Collaborator
There was a problem hiding this comment.
@dominicbarnes
My mistake. Push commit in this way doesn't push it to proper branch.
spacewander
approved these changes
Jan 25, 2018
Collaborator
|
Merged. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are buliding on CircleCI for example, pushing the commits first can lead to a race where CI env will not see the tags since the pull happened before the tags were finished pushing.
It should be fully safe (and backwards-compatible) to change the order of pushing to the remote. This should make integrating with CI tools less of a race.