Columns in git-effort adopt to file length #633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschlimm
commented
Mar 4, 2017
Author
nschlimm
left a comment
nschlimm
left a comment
There was a problem hiding this comment.
columns=$(( $(git ls-files | awk '{ print length }' | sort -rn | head -1 ) + 5 ))
shorter and also works obviously
spacewander
requested changes
Mar 5, 2017
bin/git-effort
Outdated
| # if the output won't be printed to tty, disable the color | ||
| test -t 1 && to_tty=true | ||
| color= | ||
| columns=45 |
Collaborator
There was a problem hiding this comment.
colums=45 seems duplicate now, because you will calculate it from longest filename later.
Author
There was a problem hiding this comment.
taken that out. I have another branch where you can set the columns as option on the command line when calling git effort, this was the default setting. however it's not necessary here ...
spacewander
approved these changes
Mar 6, 2017
Collaborator
|
@nschlimm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The columns in git-effort end up in a mess when you have longer file names.
I have fixed that so the column width matches the longest file in the current git repo.