Adds 2FA support to git-fork #615
Conversation
|
LGTM. |
spacewander
left a comment
spacewander
left a comment
There was a problem hiding this comment.
@nicolaiskogheim @qw3rtman
Any other ideas?
bin/git-fork
Outdated
| ssh -o BatchMode=yes [email protected] exit >/dev/null 2>&1 | ||
| ssh_exit_code=$? | ||
| if [[ "$ssh_exit_code" = 0 ]] || [[ "$ssh_exit_code" = 1 ]]; then | ||
| if ssh -T [email protected] 2>&1 | grep -qi 'success'; then |
There was a problem hiding this comment.
Enter host password for user 'spacewander':
The authenticity of host 'github.com (192.30.253.112)' can't be established.
RSA key fingerprint is SHA256:nThbg6kXUpJWGl7E1IGOCspRomTxdCARLviKw6E5SY8.
Are you sure you want to continue connecting (yes/no)? no
Is there a way to disable the prompt?
There was a problem hiding this comment.
It seems possible. However doing so would expose the user to MITM attacks.
There was a problem hiding this comment.
Maybe we could tell users what will happen before ssh?
Just don't let them surprised.
There was a problem hiding this comment.
Sure, something like echo 'Add github remote as SSH (you will be prompted to verify the server's credentials)?'
There was a problem hiding this comment.
I think Add GitHub remote branch via SSH (you will be prompted to verify the server's credentials)? could be better.
There was a problem hiding this comment.
I added and rebased
|
Merged. |
|
You're welcome :) |
3 participants
Two factor authentication support + minor linting