Skip to content

Conversation

@wcmonty
Copy link

@wcmonty wcmonty commented Aug 11, 2016

This just adds the ability to use exit to quit git-repl, in addition to the built-in quit.

@qw3rtman
Copy link
Collaborator

I'm good with this idea! For the actual code, instead of breaking exit and quit into two separate cases, you can combine them into one case like this:

quit|exit) break;;

Additionally, it would be nice to add this to the documentation here and update and regenerate the man page. 😄

@wcmonty
Copy link
Author

wcmonty commented Aug 12, 2016

@qw3rtman I updated the script to combine the cases in 554d779. The documentation has been updated in d6f505f.

@qw3rtman qw3rtman merged commit a319b6f into tj:master Aug 12, 2016
@nicolaiskogheim
Copy link
Collaborator

The man page is not organised well now.

Git read-eval-print-loop belongs under Description, and the rest should go under Examples. The Options heading can be removed.

We should perhaps have a better description, but you don't need to do that now if you don't feel like it. The other changes is overdue so I would like that handled in this PR.

@nicolaiskogheim
Copy link
Collaborator

Too late, haha.

@qw3rtman
Copy link
Collaborator

@nicolaiskogheim Merged before I saw this. You can revert if you see fit.

@nicolaiskogheim
Copy link
Collaborator

Nah, I'll open a new one :) Should be quick to do.

@nicolaiskogheim
Copy link
Collaborator

Done #569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants