Skip to content

Conversation

@eungjun-yi
Copy link

No description provided.

@hemanth
Copy link
Collaborator

hemanth commented Jul 25, 2016

Thanks!

@hemanth hemanth merged commit 859bf38 into tj:master Jul 25, 2016
@nicolaiskogheim
Copy link
Collaborator

nicolaiskogheim commented Jul 25, 2016

Thanks. It seems only natural that we try and fork the repo we're in as a default, good catch.

There is some logic that need to change, though. The rest of the script assumes that it should clone the repo, cd into it and add the argument (here $url) as a remote called 'upstream'. See this part

What we want to do in this case is just rename origin to upstream, and add the fork as origin.

The man pages also have to be updated to reflect that we will have a default value, and that git fork will do as I just described when ran without arguments.

@nicolaiskogheim
Copy link
Collaborator

A little quick on the trigger there, @hemanth ;)

@npcode We'd appreciate a new PR with the changes I suggested. Please comment if anything was unclear, or if someone has other suggestions.

@eungjun-yi
Copy link
Author

@nicolaiskogheim I've sent the pull request. Your idea is just what I wanted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants