Update windows install.cmd #497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a regression introduced by the useage of `enabledelayedexpansion`, which results in `!` treated as variable identifier like `%`. The result was that git didn't treat the scripts as git commands...
This was happening earlier as well, but the error messages were the raw messages from the failed writes...
column.exe will be available in the next git release: git-for-windows/build-extra#92 Also convert tabs to spaces... Was mixed up to now :-/
Contributor
Author
|
If the rest of this PR is controversial, please at least cherry pick the first commit, as this fixes a brown paper bug in my last PR which currently makes all installed scripts unusable on windows :-( |
Collaborator
|
Thanks, @JanSchulz! |
tardypad
pushed a commit
to tardypad/git-extras
that referenced
this pull request
Jul 13, 2016
Update windows install.cmd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enabledelayedexpansionis used -> this destroyed the shebang line and resulted in not useable commands...)