Update install.cmd

[gisphm]

1. Reduce duplicate code in the previous two for loops and copy bash_completion.sh to where it should be installed as the makefile describes.
2. Those commands in file need_git_repo actually don't need is-git-repo.

[qw3rtman]

Has this been tested?

[gisphm]

Yes, I am using it on my windows to update git-extras.

[qw3rtman]

@gisphm, what Git emulator are you using (cygwin, Git for Windows, msysgit)?

[gisphm]

Git for windows 2.6.4 64bit

[gisphm]

I have to say that this script is written for Git for Windows. It does not work with msysgit or cygwin.

[jankatins]

It took me a while to understand what this does:

 +     >NUL FINDSTR /C:%%~ni %GITEXTRAS%\need_git_repo || (
 +      TYPE %GITEXTRAS%\helper\is-git-repo >> %PREFIX%\bin\%%~ni
 +  )

>NUL prevents output from the findstr. Funny that you can write the pipe before the actual command...

Could probably easier to understand if this is refactored to

FINDSTR /C:%%~ni %GITEXTRAS%\need_git_repo >NUL 
if %errorlevel% == 0 (...)

[jankatins]

This needs a rebase... :-)

[gisphm]

😓 @JanSchulz I am not good at batch programming...