Skip to content

Conversation

@apjanke
Copy link
Contributor

@apjanke apjanke commented Oct 2, 2015

Follows up on #383, which introduced a build problem on OS X.

In an eval in a Makefile, shell variables need to have their $ escaped as $$ so they're expanded by the called shell instead of by make.

Currently, the build is breaking for me like this.

[~/local/opp/git/git-extras on ⇄ master]
$ make PREFIX=/tmp/git-extras install
usage: mktemp [-d] [-q] [-t prefix] [-u] template ...
       mktemp [-d] [-q] [-u] -t prefix
... installing bins to /tmp/git-extras/bin
... installing man pages to /tmp/git-extras/share/man/man1
usage:  chmod [-fhv] [-R [-H | -L | -P]] [-a | +a | =a  [i][# [ n]]] mode|entry file ...
    chmod [-fhv] [-R [-H | -L | -P]] [-E | -C | -N | -i | -I] file ...
make: *** [install] Error 1
[✘ ~/local/opp/git/git-extras on ⇄ master]
$

hemanth added a commit that referenced this pull request Oct 2, 2015
Makefile: escape $ used inside eval as shell variable
@hemanth hemanth merged commit faaae9f into tj:master Oct 2, 2015
@apjanke apjanke deleted the makefile-escape-mktemp branch October 2, 2015 08:30
@apjanke apjanke mentioned this pull request Oct 3, 2015
@qw3rtman qw3rtman mentioned this pull request Dec 27, 2015
tardypad pushed a commit to tardypad/git-extras that referenced this pull request Jul 13, 2016
Makefile: escape $ used inside eval as shell variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants