Skip to content

[RFC] Improve speed of git effort #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hemanth merged 5 commits into from
Jul 10, 2015
Merged

[RFC] Improve speed of git effort #392

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cb15c94
Alter options to git log. Remove pipe
nicolaiskogheim Jul 8, 2015
7397304
Parallelize git-effort with xargs
nicolaiskogheim Jul 8, 2015
203b764
perf: reduce calls to git log
nicolaiskogheim Jul 8, 2015
39238de
Remove unnecessary call to cat
nicolaiskogheim Jul 8, 2015
935c5a3
Avoid spawning subshell
nicolaiskogheim Jul 8, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 20 additions & 15 deletions bin/git-effort
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ color=
#

date() {
git log --pretty='format: %ai' $1 | cut -d ' ' -f 2
git log --pretty='format: %ad' --date=short $1
}

#
Expand All @@ -36,10 +36,7 @@ show_cursor_and_cleanup() {
#

active_days() {
date $1 | uniq | awk '
{ sum += 1 }
END { print sum }
'
uniq <(echo "$1") | wc -l
}

#
Expand All @@ -62,12 +59,13 @@ color_for() {
#

effort() {
for file in "$@"; do
commits=`git log --oneline "$file" | wc -l`
file=$1
local commit_dates=`date $file`
commits=`wc -l <<<"$(echo "$commit_dates")"`
color='90'

# ignore <= --above
test $commits -le $above && continue
test $commits -le $above && exit 0

# commits
color_for $commits
Expand All @@ -79,13 +77,13 @@ effort() {
i=$(($i+1))
done

printf " \033[${color}m%s %-10d" $f_dot $commits
msg=$(printf " \033[${color}m%s %-10d" $f_dot $commits)

# active days
active=`active_days "$file"`
active=`active_days "$commit_dates"`
color_for $active
printf "\033[${color}m %d\033[0m\n" $active
done
msg="$msg $(printf "\033[${color}m %d\033[0m\n" $active)"
echo "$msg"
}

#
Expand All @@ -106,7 +104,7 @@ sort_effort() {
clear
echo
heading
cat $tmp | sort -rn -k 2
< $tmp sort -rn -k 2
}

# --above <n-commits>
Expand Down Expand Up @@ -134,11 +132,18 @@ fi
hide_cursor
trap show_cursor_and_cleanup INT

# loop files
# export functions so subshells can call them
export -f effort
export -f color_for
export -f active_days
export -f date
export above

heading
# send files to effort
printf "%s\0" "${files[@]}" | xargs -0 -n 1 -P 4 -I % bash -c "effort \"%\"" | tee $tmp

effort "${files[@]}" | tee $tmp
# if more than one file, sort and print
test "$(wc -l $tmp | awk '{print $1}')" -gt 1 && sort_effort
echo

Expand Down