-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix minor typo in git rename-branch man page
#1211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| . | ||
| .nf | ||
|
|
||
| <old\-branch> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is generated with https://github.com/tj/git-extras/blob/main/man/Readme.md#description.
Better to fix in the original source or the generator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad I missed that, sorry.
I took a peak at the ronn rabbit hole and couldn't make it run on my system yet, I'll need more time on it, or investigate the options in #831.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I eventually managed to run ronn and generate the doc files, here I added a few notes in case it's useful to somebody else.
I'd like to ask:
- I added a new commit as per guidelines, would you like me to remove the previous revision for a cleaner history?
- I re-formatted the source file for consistency with the other
renamecommands docs, but therename-fileoptions are rendered as a definition list in the HTML: would you like me to adjust therenamedocs (and perhaps other commands), to have their options turned into DLs too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a new commit as per guidelines, would you like me to remove the previous revision for a cleaner history?
It's fine. We will squash it in the merge.
I re-formatted the source file for consistency with the other rename commands docs, but the rename-file options are rendered as a definition list in the HTML: would you like me to adjust the rename docs (and perhaps other commands), to have their options turned into DLs too?
I would recommend doing it in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend doing it in a separate PR.
Agreed, thank you!
|
@danpaolella |
Show the option as
<old-branch>and<new-branch>instead of<old-branch>and<new-branch>.