Skip to content

Conversation

@danpaolella
Copy link
Contributor

Show the option as <old-branch> and <new-branch> instead of &lt;old-branch&gt; and &lt;new-branch&gt;.

.
.nf

&lt;old\-branch&gt;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is generated with https://github.com/tj/git-extras/blob/main/man/Readme.md#description.
Better to fix in the original source or the generator.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad I missed that, sorry.
I took a peak at the ronn rabbit hole and couldn't make it run on my system yet, I'll need more time on it, or investigate the options in #831.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I eventually managed to run ronn and generate the doc files, here I added a few notes in case it's useful to somebody else.

I'd like to ask:

  1. I added a new commit as per guidelines, would you like me to remove the previous revision for a cleaner history?
  2. I re-formatted the source file for consistency with the other rename commands docs, but the rename-file options are rendered as a definition list in the HTML: would you like me to adjust the rename docs (and perhaps other commands), to have their options turned into DLs too?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a new commit as per guidelines, would you like me to remove the previous revision for a cleaner history?

It's fine. We will squash it in the merge.

I re-formatted the source file for consistency with the other rename commands docs, but the rename-file options are rendered as a definition list in the HTML: would you like me to adjust the rename docs (and perhaps other commands), to have their options turned into DLs too?

I would recommend doing it in a separate PR.

Copy link
Contributor Author

@danpaolella danpaolella Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend doing it in a separate PR.

Agreed, thank you!

@danpaolella danpaolella marked this pull request as draft September 2, 2025 14:57
@danpaolella danpaolella marked this pull request as ready for review September 2, 2025 17:04
@spacewander spacewander merged commit b57eb8b into tj:main Sep 4, 2025
6 checks passed
@spacewander
Copy link
Collaborator

@danpaolella
Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants